Skip to content

Updated cancel_link helper default label to 'Resume subscription'#26733

Merged
sagzy merged 1 commit intomainfrom
cancel-link-helper-copy-update-BER-3417
Mar 9, 2026
Merged

Updated cancel_link helper default label to 'Resume subscription'#26733
sagzy merged 1 commit intomainfrom
cancel-link-helper-copy-update-BER-3417

Conversation

@minimaluminium
Copy link
Copy Markdown
Member

ref https://linear.app/ghost/issue/BER-3417/refresh-custom-cancellation-button-state-without-manual-page-reload

The {{cancel_link}} theme helper's default continueLabel was "Continue subscription", while Portal was updated to use "Resume subscription" in #26679.

  • Updated the default continueLabel from "Continue subscription" to "Resume subscription"
  • Updated the corresponding unit test

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 43d1373b-c763-47b3-97d8-10c298d667b4

📥 Commits

Reviewing files that changed from the base of the PR and between 53d2f10 and 3db5fbd.

📒 Files selected for processing (2)
  • ghost/core/core/frontend/helpers/cancel_link.js
  • ghost/core/test/unit/frontend/helpers/cancel-link.test.js
🚧 Files skipped from review as they are similar to previous changes (2)
  • ghost/core/test/unit/frontend/helpers/cancel-link.test.js
  • ghost/core/core/frontend/helpers/cancel_link.js

Walkthrough

The pull request changes the default label text for the continue action in the cancel link helper from "Continue subscription" to "Resume subscription". The helper's documentation comment and its runtime default value were updated accordingly. The unit test expectation was adjusted to match the new default. No function signatures, control flow, exported entities, or test logic were modified.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main change: updating the cancel_link helper's default label to 'Resume subscription'.
Description check ✅ Passed The description is directly related to the changeset, providing context about why the change was made, what was changed, and confirming both the helper and test were updated.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cancel-link-helper-copy-update-BER-3417

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@minimaluminium minimaluminium requested a review from sagzy March 9, 2026 10:21
@ErisDS
Copy link
Copy Markdown
Member

ErisDS commented Mar 9, 2026

🤖 Velo CI Failure Analysis

Classification: 🔴 HARD FAIL

  • Workflow: CI
  • Failed Step: Load Image
  • Run: View failed run
    What failed: Docker login to ghcr.io failed due to a context deadline exceeded
    Why: The root cause of the failure is a Docker login error to the GitHub Container Registry (ghcr.io) due to a context deadline exceeded. This is an infrastructure issue and not a code problem, as it is related to network connectivity or a temporary issue with the external service.
    Action:
    This is likely a temporary issue with the GitHub Container Registry. Try rerunning the workflow or check the status of the registry. If the issue persists, the infrastructure team should investigate the problem.

Aligns the theme helper's default continueLabel with the Portal UI,
which was updated to use 'Resume subscription' in 8a21c7a.
@sagzy sagzy force-pushed the cancel-link-helper-copy-update-BER-3417 branch from 53d2f10 to 3db5fbd Compare March 9, 2026 12:53
@sagzy sagzy enabled auto-merge (squash) March 9, 2026 12:53
@sagzy sagzy merged commit be0ea50 into main Mar 9, 2026
30 checks passed
@sagzy sagzy deleted the cancel-link-helper-copy-update-BER-3417 branch March 9, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants