Update validateSiteUuid to be synchronous

[EvanHahn]

no ref

This function never awaits or returns a promise. Let's make it synchronous.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2fda386f-40b3-4223-9b6e-bbf3d651eb00

📥 Commits

Reviewing files that changed from the base of the PR and between 8df2622 and de35864.

📒 Files selected for processing (2)

• ghost/core/core/server/services/settings/settings-service.js
• ghost/core/test/unit/server/services/settings/settings-service.test.js

---

Walkthrough

The validateSiteUuid() method in the settings service was converted from an asynchronous function to a synchronous function. Consequently, the invocation of this method in the init function was updated to remove the await keyword. The corresponding test file was updated across six test cases to match the new synchronous implementation, removing the async keyword from test callbacks and replacing await settingsService.validateSiteUuid() calls with direct invocations.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Update validateSiteUuid to be synchronous' clearly summarizes the main change: converting an async function to synchronous.
Description check	✅ Passed	The description directly relates to the changeset, explaining that the function never awaits or returns a promise and should be made synchronous.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch make-validatesiteuuid-sync

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cmraible]

Good call, thanks for finding and improving this!