Added Content API key to built-in integrations#26772
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughA new Content API modal and route were added. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Velo CI Failure AnalysisClassification: 🟠 SOFT FAIL
|
81ce943 to
41ab644
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@apps/admin-x-settings/src/components/settings/advanced/integrations/content-api-modal.tsx`:
- Line 4: The import is using the deprecated package; update the import for the
components used in this file (Button, Icon, Modal) to come from the new design
system by replacing the existing import from '@tryghost/admin-x-design-system'
with imports from '@tryghost/shade' (or the equivalent named exports in shade),
and adjust any prop or API differences on the Button, Icon, or Modal usages in
this file (e.g., component names or prop names) so they match the
`@tryghost/shade` API (target symbols: Button, Icon, Modal in
content-api-modal.tsx).
- Line 25: The external link in content-api-modal.tsx uses the Button component
with target='_blank' but no rel attribute, which is a security/lint risk; update
the ButtonProps interface to accept a rel string (add rel?: string to the props
that currently extend HTMLProps<HTMLButtonElement>) and pass rel='noopener
noreferrer' when rendering the Button in the Content API modal, or alternatively
replace the Button usage with a native <a> anchor element that includes
target='_blank' and rel='noopener noreferrer'; modify the Button declaration
(ButtonProps / Button component) and the usage in the
integrations/content-api-modal.tsx render to ensure rel is provided for external
links.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: eb97e28c-1713-4cbd-8c42-b248dd61aa9e
📒 Files selected for processing (4)
apps/admin-x-settings/src/components/providers/routing/modals.tsxapps/admin-x-settings/src/components/providers/settings-router.tsxapps/admin-x-settings/src/components/settings/advanced/integrations.tsxapps/admin-x-settings/src/components/settings/advanced/integrations/content-api-modal.tsx
apps/admin-x-settings/src/components/settings/advanced/integrations/content-api-modal.tsx
Show resolved
Hide resolved
apps/admin-x-settings/src/components/settings/advanced/integrations/content-api-modal.tsx
Outdated
Show resolved
Hide resolved
apps/admin-x-settings/src/components/settings/advanced/integrations/content-api-modal.tsx
Outdated
Show resolved
Hide resolved
apps/admin-x-settings/src/components/settings/advanced/integrations/content-api-modal.tsx
Show resolved
Hide resolved
|



ref https://linear.app/ghost/issue/BER-2416/starter-customers-cannot-obtain-a-content-api-key