Skip to content

Updated mini Koenig editor text inhereitence#26803

Merged
weylandswart merged 1 commit intomainfrom
weyland-des-1310-font-size-regression-in-settings-mini-koenig-editor
Mar 12, 2026
Merged

Updated mini Koenig editor text inhereitence#26803
weylandswart merged 1 commit intomainfrom
weyland-des-1310-font-size-regression-in-settings-mini-koenig-editor

Conversation

@weylandswart
Copy link
Copy Markdown
Contributor

Closes https://linear.app/ghost/issue/DES-1310/font-size-regression-in-settings-mini-koenig-editor

Regression from the TW4 update. Also fixed for Newsletters and Announcements Bar.

Before After
Screenshot 2026-03-12 at 15 32 50 Screenshot 2026-03-12 at 15 32 15

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d0abab90-0531-4e21-8725-0564aa26305c

📥 Commits

Reviewing files that changed from the base of the PR and between 54cb356 and 443909f.

📒 Files selected for processing (1)
  • apps/admin-x-design-system/src/global/form/koenig-editor-base.tsx

Walkthrough

A CSS class string literal in the Koenig editor base component was modified. When font style inheritance is enabled, the styling approach changed from using text-inherit to using inline [font-size:inherit]. This adjustment affects how font properties cascade in the editor wrapper element. The modification does not alter the component's control flow, public API, or functionality—only the CSS value applied for font inheritance behavior.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title refers to the Koenig editor text inheritance fix, which matches the main change in the PR (font-size inheritance in the mini Koenig editor).
Description check ✅ Passed The description clearly documents the fix for a font-size regression in the mini Koenig editor, includes before/after screenshots, and references the related Linear issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch weyland-des-1310-font-size-regression-in-settings-mini-koenig-editor
📝 Coding Plan for PR comments
  • Generate coding plan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@weylandswart weylandswart merged commit 465c20f into main Mar 12, 2026
29 checks passed
@weylandswart weylandswart deleted the weyland-des-1310-font-size-regression-in-settings-mini-koenig-editor branch March 12, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant