Skip to content

Fixed broken space-* utility on Dialog#26805

Merged
weylandswart merged 1 commit intomainfrom
weyland-des-1311-space-x-classes-in-activitypub-dont-work
Mar 12, 2026
Merged

Fixed broken space-* utility on Dialog#26805
weylandswart merged 1 commit intomainfrom
weyland-des-1311-space-x-classes-in-activitypub-dont-work

Conversation

@weylandswart
Copy link
Copy Markdown
Contributor

Closes https://linear.app/ghost/issue/DES-1311/space-x-classes-in-activitypub-dont-work

Tailwind v4 doesn't like the space-* utility bound to responsive classes (Like sm:). This PR tweaks it to gap which works more reliably. Tested across a few different Dialog implementations.

Before After
Screenshot 2026-03-12 at 16 37 37 Screenshot 2026-03-12 at 16 37 17

Closes https://linear.app/ghost/issue/DES-1311/space-x-classes-in-activitypub-dont-work

Tailwind v4 doesn't like the space utility bound to responsive classes. Tweaks it to gap which works more reliably.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8625939f-15e4-4327-b67c-3e2ade61c23a

📥 Commits

Reviewing files that changed from the base of the PR and between 465c20f and 02ccf3b.

📒 Files selected for processing (1)
  • apps/shade/src/components/ui/dialog.tsx

Walkthrough

The pull request modifies the DialogFooter component in the dialog component file. The responsive spacing utility for small screens changes from sm:space-x-2 to sm:gap-2. This switches the spacing mechanism between footer buttons from using horizontal margin spacing to using gap-based spacing on small screen sizes. No changes are made to exported or public entity signatures.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: replacing a broken space-* utility with gap in the Dialog component, which matches the primary modification in the changeset.
Description check ✅ Passed The description is directly related to the changeset, explaining the Tailwind v4 compatibility issue and why space-* was replaced with gap, and includes testing confirmation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch weyland-des-1311-space-x-classes-in-activitypub-dont-work
📝 Coding Plan for PR comments
  • Generate coding plan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@weylandswart weylandswart merged commit 0a044c6 into main Mar 12, 2026
29 checks passed
@weylandswart weylandswart deleted the weyland-des-1311-space-x-classes-in-activitypub-dont-work branch March 12, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant