Skip to content

Fixed broken space utilities for alert dialog and sheet#26812

Merged
weylandswart merged 1 commit intomainfrom
alert-dialog-and-sheet-broken-space-utilities
Mar 12, 2026
Merged

Fixed broken space utilities for alert dialog and sheet#26812
weylandswart merged 1 commit intomainfrom
alert-dialog-and-sheet-broken-space-utilities

Conversation

@weylandswart
Copy link
Copy Markdown
Contributor

No ref

The same issue as https://linear.app/ghost/issue/DES-1311/space-x-classes-in-activitypub-dont-work

Fixed for alert dialog and sheet

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dcf730a0-7eb7-4202-a8db-e021bfed4d7b

📥 Commits

Reviewing files that changed from the base of the PR and between 9955ebb and 91171d5.

📒 Files selected for processing (2)
  • apps/shade/src/components/ui/alert-dialog.tsx
  • apps/shade/src/components/ui/sheet.tsx

Walkthrough

Two footer components in the UI library have been updated with modified Tailwind spacing utilities. In both AlertDialogFooter and SheetFooter, the sm:space-x-2 utility class was replaced with sm:gap-2. This change modifies how spacing is applied between child elements at the small breakpoint and larger screen sizes.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fixed broken space utilities for alert dialog and sheet' accurately describes the main changes: replacing space-x-2 with gap-2 utilities in both alert-dialog.tsx and sheet.tsx components.
Description check ✅ Passed The description is related to the changeset, referencing a similar issue (DES-1311) and specifying the components affected (alert dialog and sheet), though it could be more detailed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch alert-dialog-and-sheet-broken-space-utilities
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@weylandswart weylandswart merged commit 4ee5071 into main Mar 12, 2026
29 checks passed
@weylandswart weylandswart deleted the alert-dialog-and-sheet-broken-space-utilities branch March 12, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant