Skip to content

Fixed browser test for privacy page#26879

Merged
9larsons merged 1 commit intomainfrom
fix-private-page-browser-test
Mar 18, 2026
Merged

Fixed browser test for privacy page#26879
9larsons merged 1 commit intomainfrom
fix-private-page-browser-test

Conversation

@troyciesco
Copy link
Contributor

ref #26762

  • privacy pages were updated, but browser tests reference the old flow
  • this fixes them to use the new flow, whereby the user clicks "Enter access code" and the input and button are visible

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: efe0d6ec-05d7-429c-9458-554465b0a2e8

📥 Commits

Reviewing files that changed from the base of the PR and between d6265e8 and e12ba9a.

📒 Files selected for processing (1)
  • ghost/core/test/e2e-browser/admin/private-site.spec.js

Walkthrough

The test file for private site functionality was updated to modify how it validates private site access. The test now checks for specific URL path parameters, verifies the visibility of an "Enter access code" link, and validates the presence of an access code entry dialog with an Enter button. The interaction flow was changed to navigate through the access code entry mechanism instead of a direct button click.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fixed browser test for privacy page' directly and clearly describes the main change: updating a browser test for the privacy page feature.
Description check ✅ Passed The description is directly related to the changeset, explaining that privacy pages were updated and browser tests needed to be fixed to match the new flow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-private-page-browser-test
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@9larsons 9larsons enabled auto-merge (squash) March 18, 2026 17:52
@9larsons 9larsons merged commit 6629dfd into main Mar 18, 2026
34 checks passed
@9larsons 9larsons deleted the fix-private-page-browser-test branch March 18, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants