Skip to content

Added private.min.js to gitignore#26903

Merged
cmraible merged 1 commit intomainfrom
add-private-min-js-to-gitignore
Mar 19, 2026
Merged

Added private.min.js to gitignore#26903
cmraible merged 1 commit intomainfrom
add-private-min-js-to-gitignore

Conversation

@cmraible
Copy link
Copy Markdown
Collaborator

@cmraible cmraible commented Mar 19, 2026

no refs

This build artifact shouldn't be committed since it's generated as part of the build pipeline, but it wasn't included in .gitignore. This adds it to prevent anyone from accidentally committing it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: edf591dc-ab24-485f-be74-63206e07657b

📥 Commits

Reviewing files that changed from the base of the PR and between 4bdc6aa and 037c019.

📒 Files selected for processing (1)
  • .gitignore

Walkthrough

The .gitignore file was updated to add one new entry that excludes a built frontend asset from version control. Specifically, the minified JavaScript file at /ghost/core/core/frontend/public/private.min.js is now ignored, aligning with existing patterns that exclude similar bundled minified public JavaScript files. This is a minimal change with one line added and no lines removed.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding private.min.js to gitignore, which matches the single file modification in the changeset.
Description check ✅ Passed The description is directly related to the changeset, explaining why private.min.js should be added to gitignore and providing context about it being a generated build artifact.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-private-min-js-to-gitignore
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cmraible cmraible marked this pull request as ready for review March 19, 2026 23:38
@cmraible cmraible enabled auto-merge (squash) March 19, 2026 23:47
@cmraible cmraible merged commit 25c7662 into main Mar 19, 2026
33 checks passed
@cmraible cmraible deleted the add-private-min-js-to-gitignore branch March 19, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant