Merged
Conversation
github-actions
bot
added
the
dependencies
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26907 +/- ##
==========================================
- Coverage 73.12% 73.12% -0.01%
==========================================
Files 1537 1537
Lines 121397 121403 +6
Branches 14666 14666
==========================================
- Hits 88775 88773 -2
- Misses 31593 31623 +30
+ Partials 1029 1007 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 23383375709 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
The upstream Koenig packages have been migrated from JavaScript to TypeScript, which changes their module format and export structure. This update bumps all @tryghost/kg-* and @tryghost/koenig-lexical packages to their latest versions and adapts Ghost's codebase to work with the new builds: - Updated CJS require() calls to use .default where the TypeScript build uses default exports (mobiledoc.js, json-to-html.js, email-renderer.js, markdown-renderer.js, clean-basic-html util) - Fixed the UnsplashSearchModal onImageInsert prop to match the exported InsertImagePayload type from kg-unsplash-selector - Added react/jsx-runtime and react-dom/server as UMD globals in the Ember app route so Koenig UMD bundles resolve them at runtime - Increased test timeout for HTML conversion tests to accommodate slower first-run initialization of the new TypeScript-built packages
kevinansfield
force-pushed
the
renovate/koenig-packages
branch
from
d1ccab8 to
dc012cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream Koenig packages have been migrated from JavaScript to TypeScript, which changes their module format and export structure. This update bumps all
@tryghost/kg-*and@tryghost/koenig-lexicalpackages to their latest versions and adapts Ghost's codebase to work with the new builds:require()calls to use.defaultwhere the TypeScript build uses default exports (mobiledoc.js,json-to-html.js,email-renderer.js,markdown-renderer.js, clean-basic-html util)UnsplashSearchModalonImageInsertprop to match the exportedInsertImagePayloadtype fromkg-unsplash-selectorreact/jsx-runtimeandreact-dom/serveras UMD globals in the Ember app route so Koenig UMD bundles resolve them at runtime