Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
WalkthroughThe change enables TypeScript compiler option 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
EvanHahn
force-pushed
the
claude/great-wing
branch
2 times, most recently
from
ebd21d5 to
f184dae
Compare
no ref **What?** This enables [TypeScript's `erasableSyntaxOnly` option][0] across the codebase. This means we can't use enums, namespaces, or a few other things. This change should have no user impact. **Why?** The big reason: [Node supports running TypeScript files directly][1], but only if all the syntax is erasable. This means we can remove build steps in many cases! It has a few other advantages, too: simplifying source maps, restricting some tricky parts of TypeScript, slightly accelerating TypeScript compilation, This doesn't enable some of the other options that are sometimes recommended in tandem, like `verbatimModuleSyntax`. Nor does it actually run `.ts` files with Node. Those are for another day. [0]: https://www.typescriptlang.org/tsconfig/#erasableSyntaxOnly [1]: https://nodejs.org/api/typescript.html#type-stripping
EvanHahn
force-pushed
the
claude/great-wing
branch
from
f184dae to
0747411
Compare
EvanHahn
added
the
ok to merge for me
Changelog for v1.4.0 -> 1.4.1:
Changelog for v2.67.0 -> 2.67.1:
|
2 participants
no ref
What? This enables TypeScript's
erasableSyntaxOnlyoption across the codebase. This means we can't use enums, namespaces, or a few other things. This change should have no user impact.Why? The big reason: Node supports running TypeScript files directly, but only if all the syntax is erasable. This means we can remove build steps in many cases! It has a few other advantages, too: simplifying source maps, restricting some tricky parts of TypeScript, slightly accelerating TypeScript compilation,
This doesn't enable some of the other options that are sometimes recommended in tandem, like
verbatimModuleSyntax. Nor does it actually run.tsfiles with Node. Those are for another day.