Skip to content

Removed welcome email editor feature flag#26916

Merged
EvanHahn merged 3 commits intomainfrom
claude/quirky-nobel
Mar 25, 2026
Merged

Removed welcome email editor feature flag#26916
EvanHahn merged 3 commits intomainfrom
claude/quirky-nobel

Conversation

@EvanHahn
Copy link
Contributor

closes https://linear.app/ghost/issue/NY-1105

This change should have no user impact. All it does is remove the flag, enabling the feature for everyone.

In addition to automated tests, I manually verified that the new welcome email editor shows up.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cc085315-5a5b-4ec0-bd06-3e76255a9879

📥 Commits

Reviewing files that changed from the base of the PR and between 728105e and eba4b01.

⛔ Files ignored due to path filters (1)
  • ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • ghost/core/core/shared/labs.js
💤 Files with no reviewable changes (1)
  • ghost/core/core/shared/labs.js

Walkthrough

The PR removes the welcomeEmailEditor feature flag from GA feature lists and related conditional logic. WelcomeEmailModal no longer checks the flag and always renders the EmailPreviewModalContent layout (header actions, Test dropdown, subject TextField, MemberEmailEditor, and lexical Hint). Tests were updated to stop mocking labs.welcomeEmailEditor and to use configs reflecting Tenor settings where needed. The welcomeEmailEditor flag is no longer force-enabled in E2E/test flows via the GA features list.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly describes the main change: removing the welcome email editor feature flag to enable the feature for all users.
Description check ✅ Passed The description is related to the changeset, explaining the purpose (removing the flag), expected impact, and verification steps taken by the author.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/quirky-nobel

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EvanHahn EvanHahn marked this pull request as ready for review March 23, 2026 20:35
@EvanHahn EvanHahn requested a review from 9larsons March 23, 2026 20:40
closes https://linear.app/ghost/issue/NY-1105

This change should have no user impact. All it does is remove the flag,
enabling the feature for everyone.

In addition to automated tests, I manually verified that the new welcome
email editor shows up.
@EvanHahn EvanHahn force-pushed the claude/quirky-nobel branch from ccb43d8 to 7131015 Compare March 24, 2026 13:58
@EvanHahn EvanHahn added the ok to merge for me You can merge this on my behalf if you want. label Mar 24, 2026
@EvanHahn EvanHahn enabled auto-merge (squash) March 25, 2026 20:11
@EvanHahn EvanHahn merged commit b3bd8d1 into main Mar 25, 2026
34 checks passed
@EvanHahn EvanHahn deleted the claude/quirky-nobel branch March 25, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok to merge for me You can merge this on my behalf if you want.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants