Conversation
ref https://linear.app/ghost/issue/DES-1321 Aligned Shade Storybook dependencies and config with Storybook 10 ESM requirements and fixed MDX provider resolution for successful static builds.
ref https://linear.app/ghost/issue/DES-1321 Added a dedicated shade path filter, setup output, and required CI job that builds Shade Storybook when relevant changes are detected.
ref https://linear.app/ghost/issue/DES-1321 Kept the Storybook 10 migration focused on local toolchain changes by removing the added CI workflow job and related path/output wiring.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughStorybook config for apps/shade was updated to use ESM-derived 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/shade/.storybook/main.tsx`:
- Line 42: The alias entry that maps {find: 'crypto', replacement:
require.resolve('rollup-plugin-node-builtins')} is incorrect because it points
to a Rollup plugin rather than a crypto polyfill; update that alias in the
Storybook Vite config (the alias object in apps/shade/.storybook/main.tsx) to
point to a proper polyfill such as 'crypto-browserify' (or remove the alias if
crypto is unused), e.g. replace the replacement value with
require.resolve('crypto-browserify') and ensure the polyfill is installed as a
dependency so imports of 'crypto' are resolved correctly in Storybook.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d93cccf7-7a33-491b-bb42-7ca4cfa2dab8
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (2)
apps/shade/.storybook/main.tsxapps/shade/package.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27012 +/- ##
==========================================
- Coverage 73.20% 73.19% -0.01%
==========================================
Files 1540 1540
Lines 121786 121786
Branches 14713 14710 -3
==========================================
- Hits 89149 89141 -8
- Misses 31627 31636 +9
+ Partials 1010 1009 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ref https://linear.app/ghost/issue/DES-1321 Replaced deprecated scoped @storybook/test import with storybook/test to align with Storybook 10 package exports and avoid hoisted version fragility.
ref https://linear.app/ghost/issue/DES-1321 Removed the incorrect rollup-plugin-node-builtins alias for crypto in Storybook Vite config and cleaned up unused createRequire import.
|
ref https://linear.app/ghost/issue/DES-1321/update-shade-storybook - Upgraded Shade Storybook to latest version so that we can utilize all the new features



ref https://linear.app/ghost/issue/DES-1321/update-shade-storybook