Skip to content

Fixed Nx cache outputs for parse-email-address package#27018

Open
EvanHahn wants to merge 1 commit intomainfrom
parse-email-address-nx-fix
Open

Fixed Nx cache outputs for parse-email-address package#27018
EvanHahn wants to merge 1 commit intomainfrom
parse-email-address-nx-fix

Conversation

@EvanHahn
Copy link
Copy Markdown
Contributor

no ref

The build target compiled to build/ but Nx's default cache outputs only tracked dist, es, types, and umd, causing the directory to be missing after cache hits.

no ref

The build target compiled to `build/` but Nx's default cache outputs
only tracked `dist`, `es`, `types`, and `umd`, causing the directory to
be missing after cache hits.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: aa166a77-1346-4041-815a-56218d496738

📥 Commits

Reviewing files that changed from the base of the PR and between c310fc7 and 4810eb0.

📒 Files selected for processing (1)
  • ghost/parse-email-address/package.json

Walkthrough

An Nx configuration block has been added to the package.json file for the parse-email-address package. This configuration specifies the build target with its output directory set to build (relative to the project root). The addition comprises 7 new lines with no modifications to existing code or exported APIs.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing Nx cache outputs for the parse-email-address package to include the build directory.
Description check ✅ Passed The description clearly explains the problem and solution: the build target outputs to build/ but Nx's cache only tracked other directories, and this PR fixes that by updating cache outputs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch parse-email-address-nx-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@EvanHahn EvanHahn requested a review from 9larsons March 31, 2026 12:28
Copy link
Copy Markdown
Contributor

@9larsons 9larsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (non-blocking): /build is an outlier here and /dist is the nx default, should we just be using that?

EvanHahn added a commit that referenced this pull request Apr 15, 2026
ref #27018 (review)

This change should have no user impact.

Let's use Nx's standard output dir for this package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants