Update Spanish translations in portal.json#27025
Conversation
Added two missing strings for the new retention offers. They were provided by a Pro customer.
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughIn 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ghost/i18n/locales/es/portal.json`:
- Line 75: Update the Spanish translation for the key "Enjoy {amountOff} off
forever." in portal.json to use natural Spanish word order and include the
missing punctuation; replace the value "Disfruta de un {amountOff} descuento
para siempre" with "Disfruta de {amountOff} de descuento para siempre." so the
interpolation {amountOff} reads correctly and the sentence ends with a period.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6bf0a094-2b26-431c-a0af-fa633d80c3ff
📒 Files selected for processing (1)
ghost/i18n/locales/es/portal.json
ghost/i18n/locales/es/portal.json
Outdated
| "Emails disabled": "Correos electrónicos desactivados", | ||
| "Ends {offerEndDate}": "Termina el {offerEndDate}", | ||
| "Enjoy {amountOff} off forever.": "", | ||
| "Enjoy {amountOff} off forever.": "Disfruta de un {amountOff} descuento para siempre", |
There was a problem hiding this comment.
Adjust Spanish phrasing for {amountOff} interpolation
Line 75 reads unnaturally in Spanish and drops final punctuation. Prefer: Disfruta de {amountOff} de descuento para siempre.
Suggested fix
- "Enjoy {amountOff} off forever.": "Disfruta de un {amountOff} descuento para siempre",
+ "Enjoy {amountOff} off forever.": "Disfruta de {amountOff} de descuento para siempre.",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Enjoy {amountOff} off forever.": "Disfruta de un {amountOff} descuento para siempre", | |
| "Enjoy {amountOff} off forever.": "Disfruta de {amountOff} de descuento para siempre.", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@ghost/i18n/locales/es/portal.json` at line 75, Update the Spanish translation
for the key "Enjoy {amountOff} off forever." in portal.json to use natural
Spanish word order and include the missing punctuation; replace the value
"Disfruta de un {amountOff} descuento para siempre" with "Disfruta de
{amountOff} de descuento para siempre." so the interpolation {amountOff} reads
correctly and the sentence ends with a period.
cathysarisky
left a comment
There was a problem hiding this comment.
Hey @bobvaneck - do you want to ask the customer about the comments below, or you want me to just merge it as-is? Since we currently have nothing and they'd be seeing English, possibly poor Spanish wording is probably an improvement? :)
ghost/i18n/locales/es/portal.json
Outdated
| "Emails disabled": "Correos electrónicos desactivados", | ||
| "Ends {offerEndDate}": "Termina el {offerEndDate}", | ||
| "Enjoy {amountOff} off forever.": "", | ||
| "Enjoy {amountOff} off forever.": "Disfruta de un {amountOff} descuento para siempre", |
There was a problem hiding this comment.
🤖 AI: I think there might be a small grammar issue here: "Disfruta de un {amountOff} descuento para siempre" sounds a bit off in Spanish. Would "Disfruta de un descuento de {amountOff} para siempre" or "Disfruta de {amountOff} de descuento para siempre" be more natural while keeping the same meaning?
There was a problem hiding this comment.
Hmm this came directly from a Spanish speaking customer, but I have to agree that the last option is actually the best one, it just lacks the "un" part, so it should be "Disfruta de un {amountOff} de descuento para siempre".
added missing "de" to the string
|



Added two missing strings for the new retention offers. They were provided by a Pro customer.