Skip to content

Update Spanish translations in portal.json#27025

Merged
cathysarisky merged 2 commits intomainfrom
bobvaneck-patch-1
Apr 7, 2026
Merged

Update Spanish translations in portal.json#27025
cathysarisky merged 2 commits intomainfrom
bobvaneck-patch-1

Conversation

@bobvaneck
Copy link
Copy Markdown
Member

Added two missing strings for the new retention offers. They were provided by a Pro customer.

Added two missing strings for the new retention offers. They were provided by a Pro customer.
@cursor
Copy link
Copy Markdown

cursor bot commented Mar 31, 2026

You have used all of your free Bugbot PR reviews.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 78e0f9ec-f8e4-4a1f-9b56-8730c86c53f0

📥 Commits

Reviewing files that changed from the base of the PR and between e65395c and 6f078c1.

📒 Files selected for processing (1)
  • ghost/i18n/locales/es/portal.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • ghost/i18n/locales/es/portal.json

Walkthrough

In ghost/i18n/locales/es/portal.json, two previously empty Spanish translation entries were populated: the message containing the {amountOff} placeholder ("Enjoy {amountOff} off forever.") and the action "No thanks, I want to cancel". No keys, placeholders, or other file content were modified.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating Spanish translations in the portal.json file.
Description check ✅ Passed The description is related to the changeset, explaining that two missing Spanish strings for retention offers were added to portal.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bobvaneck-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@ghost/i18n/locales/es/portal.json`:
- Line 75: Update the Spanish translation for the key "Enjoy {amountOff} off
forever." in portal.json to use natural Spanish word order and include the
missing punctuation; replace the value "Disfruta de un {amountOff} descuento
para siempre" with "Disfruta de {amountOff} de descuento para siempre." so the
interpolation {amountOff} reads correctly and the sentence ends with a period.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6bf0a094-2b26-431c-a0af-fa633d80c3ff

📥 Commits

Reviewing files that changed from the base of the PR and between d2ca5cc and e65395c.

📒 Files selected for processing (1)
  • ghost/i18n/locales/es/portal.json

"Emails disabled": "Correos electrónicos desactivados",
"Ends {offerEndDate}": "Termina el {offerEndDate}",
"Enjoy {amountOff} off forever.": "",
"Enjoy {amountOff} off forever.": "Disfruta de un {amountOff} descuento para siempre",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Adjust Spanish phrasing for {amountOff} interpolation

Line 75 reads unnaturally in Spanish and drops final punctuation. Prefer: Disfruta de {amountOff} de descuento para siempre.

Suggested fix
-    "Enjoy {amountOff} off forever.": "Disfruta de un {amountOff} descuento para siempre",
+    "Enjoy {amountOff} off forever.": "Disfruta de {amountOff} de descuento para siempre.",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"Enjoy {amountOff} off forever.": "Disfruta de un {amountOff} descuento para siempre",
"Enjoy {amountOff} off forever.": "Disfruta de {amountOff} de descuento para siempre.",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@ghost/i18n/locales/es/portal.json` at line 75, Update the Spanish translation
for the key "Enjoy {amountOff} off forever." in portal.json to use natural
Spanish word order and include the missing punctuation; replace the value
"Disfruta de un {amountOff} descuento para siempre" with "Disfruta de
{amountOff} de descuento para siempre." so the interpolation {amountOff} reads
correctly and the sentence ends with a period.

Copy link
Copy Markdown
Member

@cathysarisky cathysarisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bobvaneck - do you want to ask the customer about the comments below, or you want me to just merge it as-is? Since we currently have nothing and they'd be seeing English, possibly poor Spanish wording is probably an improvement? :)

"Emails disabled": "Correos electrónicos desactivados",
"Ends {offerEndDate}": "Termina el {offerEndDate}",
"Enjoy {amountOff} off forever.": "",
"Enjoy {amountOff} off forever.": "Disfruta de un {amountOff} descuento para siempre",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI: I think there might be a small grammar issue here: "Disfruta de un {amountOff} descuento para siempre" sounds a bit off in Spanish. Would "Disfruta de un descuento de {amountOff} para siempre" or "Disfruta de {amountOff} de descuento para siempre" be more natural while keeping the same meaning?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this came directly from a Spanish speaking customer, but I have to agree that the last option is actually the best one, it just lacks the "un" part, so it should be "Disfruta de un {amountOff} de descuento para siempre".

added missing "de" to the string
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 6, 2026

@cathysarisky cathysarisky merged commit ef0e5f9 into main Apr 7, 2026
39 checks passed
@cathysarisky cathysarisky deleted the bobvaneck-patch-1 branch April 7, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants