Skip to content

Removed "Refresh required" banner#27028

Merged
kevinansfield merged 1 commit intomainfrom
remove-refresh-required
Mar 31, 2026
Merged

Removed "Refresh required" banner#27028
kevinansfield merged 1 commit intomainfrom
remove-refresh-required

Conversation

@kevinansfield
Copy link
Copy Markdown
Member

no issue

  • the banner trigger was removed when running under the React Admin shell but has re-surfaced unintentionally when related "dead" code was cleaned up
  • removed all version check/refresh banner related code from the Ember Admin to prevent any further accidental triggers

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9daf217f-0be1-4d45-9c75-65b460a010a1

📥 Commits

Reviewing files that changed from the base of the PR and between d70670a and 41bdc86.

📒 Files selected for processing (3)
  • ghost/admin/app/services/ajax.js
  • ghost/admin/app/services/upgrade-status.js
  • ghost/admin/app/templates/application.hbs
💤 Files with no reviewable changes (3)
  • ghost/admin/app/templates/application.hbs
  • ghost/admin/app/services/upgrade-status.js
  • ghost/admin/app/services/ajax.js

Walkthrough

The changes remove the "refresh required" upgrade notification system: the semver comparison in ghost/admin/app/services/ajax.js that set a refresh flag when the server version exceeded the client version was deleted; the @tracked refreshRequired property was removed from ghost/admin/app/services/upgrade-status.js; and the conditional UI block in ghost/admin/app/templates/application.hbs that rendered the refresh banner was removed.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Removed "Refresh required" banner' is clear and directly reflects the main change—removal of the refresh required banner from the Ember Admin.
Description check ✅ Passed The description relates to the changeset by explaining why the refresh banner code was removed and what problem it solves.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-refresh-required

Comment @coderabbitai help to get the list of available commands and usage tips.

no issue

- the banner trigger was removed when running under the React Admin shell but has re-surfaced unintentionally when related "dead" code was cleaned up
- removed all version check/refresh banner related code from the Ember Admin to prevent any further accidental triggers
@kevinansfield kevinansfield force-pushed the remove-refresh-required branch from d70670a to 41bdc86 Compare March 31, 2026 12:20
@sonarqubecloud
Copy link
Copy Markdown

@kevinansfield kevinansfield enabled auto-merge (squash) March 31, 2026 12:24
@kevinansfield kevinansfield merged commit 450d162 into main Mar 31, 2026
34 checks passed
@kevinansfield kevinansfield deleted the remove-refresh-required branch March 31, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants