Skip to content

Added dormant private feature flag for drip sequences#27054

Merged
EvanHahn merged 1 commit intomainfrom
evanhahn-ny-1187-add-private-feature-flag-for-drip-sequences
Apr 1, 2026
Merged

Added dormant private feature flag for drip sequences#27054
EvanHahn merged 1 commit intomainfrom
evanhahn-ny-1187-add-private-feature-flag-for-drip-sequences

Conversation

@EvanHahn
Copy link
Copy Markdown
Contributor

@EvanHahn EvanHahn commented Apr 1, 2026

closes https://linear.app/ghost/issue/NY-1187

Screenshot

This change should have no user impact.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ada4162c-3686-47ee-9a35-ec36abab1e6a

📥 Commits

Reviewing files that changed from the base of the PR and between 74ede88 and 8dd3a5f.

⛔ Files ignored due to path filters (1)
  • ghost/core/test/e2e-api/admin/__snapshots__/config.test.js.snap is excluded by !**/*.snap
📒 Files selected for processing (2)
  • apps/admin-x-settings/src/components/settings/advanced/labs/private-features.tsx
  • ghost/core/core/shared/labs.js
✅ Files skipped from review due to trivial changes (1)
  • apps/admin-x-settings/src/components/settings/advanced/labs/private-features.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • ghost/core/core/shared/labs.js

Walkthrough

This change introduces a new "Drip Sequences" feature flag. The admin settings UI for private lab features now includes a dripSequences entry, rendering an additional toggle labeled "Enable welcome email drip sequences". The core labs configuration registers dripSequences as a private feature, adds it to the writable keys allowlist, and includes it in the aggregated flag list returned by getAllFlags(). No other functionality or public APIs were modified.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a dormant private feature flag for drip sequences, matching the file modifications and PR objectives.
Description check ✅ Passed The description is related to the changeset, referencing the linear issue and confirming the purpose of adding a dormant private feature flag for drip sequences.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch evanhahn-ny-1187-add-private-feature-flag-for-drip-sequences

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EvanHahn EvanHahn force-pushed the evanhahn-ny-1187-add-private-feature-flag-for-drip-sequences branch from 74ede88 to 2db9578 Compare April 1, 2026 15:03
@EvanHahn EvanHahn force-pushed the evanhahn-ny-1187-add-private-feature-flag-for-drip-sequences branch from 2db9578 to 8dd3a5f Compare April 1, 2026 15:04
@EvanHahn EvanHahn enabled auto-merge (squash) April 1, 2026 15:04
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 1, 2026

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

@EvanHahn EvanHahn merged commit 643a114 into main Apr 1, 2026
37 checks passed
@EvanHahn EvanHahn deleted the evanhahn-ny-1187-add-private-feature-flag-for-drip-sequences branch April 1, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant