Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
WalkthroughThe changes standardize 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
d724b24 to
ff452d9
Compare
no issue Ghost core uses SafeString instanceof checks in frontend helpers, so this update also aligns split with the shared frontend Handlebars runtime to avoid constructor mismatches when multiple handlebars copies are installed.
ff452d9 to
4564c27
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27081 +/- ##
=======================================
Coverage 73.19% 73.20%
=======================================
Files 1531 1531
Lines 121796 121796
Branches 14695 14698 +3
=======================================
+ Hits 89154 89164 +10
+ Misses 31625 31615 -10
Partials 1017 1017
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|



What
ghost/core's explicithandlebarsdependency from4.7.8to4.7.9splithelper and its unit test to use Ghost's frontend Handlebars runtime consistently when multiplehandlebarscopies are presentWhy
Ghost core frontend helpers rely on
SafeStringconstructor identity. If one helper createsSafeStringvalues from a differenthandlebarsmodule instance than another helper checks withinstanceof, those values stop matching even though they look identical. Using the shared frontend Handlebars runtime keeps helper behavior consistent across dependency layouts.