Merged
Conversation
ref 353552f We recently added some tests which generate new snapshots, but forgot to commit them. This fixes that. All I did was run `cd ghost/core && yarn test:e2e`. I don't really know what this snapshot is about.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
EvanHahn
added a commit
that referenced
this pull request
Apr 2, 2026
ref #27083 ref 353552f Here's the prompt I gave to Claude Sonnet 4.6: > When I ran `cd ghost/core && yarn test:e2e` on a fresh clone, new > snapshots were generated, and `git status` wasn't clean. That's not > what I want! > > Update the GitHub CI scripts so that, if `git diff`/`git status` isn't > empty after running tests, CI fails.
aileen
approved these changes
Apr 2, 2026
Member
aileen
left a comment
aileen
left a comment
There was a problem hiding this comment.
Sorry! And thank you for cleaning up after me 🙏
EvanHahn
added a commit
that referenced
this pull request
Apr 2, 2026
ref #27083 ref 353552f Here's the prompt I gave to Claude Sonnet 4.6: > When I ran `cd ghost/core && yarn test:e2e` on a fresh clone, new > snapshots were generated, and `git status` wasn't clean. That's not > what I want! > > Update the GitHub CI scripts so that, if `git diff`/`git status` isn't > empty after running tests, CI fails.
EvanHahn
added a commit
that referenced
this pull request
Apr 2, 2026
ref #27083 ref 353552f Here's the prompt I gave to Claude Sonnet 4.6: > When I ran `cd ghost/core && yarn test:e2e` on a fresh clone, new > snapshots were generated, and `git status` wasn't clean. That's not > what I want! > > Update the GitHub CI scripts so that, if `git diff`/`git status` isn't > empty after running tests, CI fails.
Contributor
Author
|
All good!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref 353552f
ref #27084
We recently added some tests which generate new snapshots, but forgot to commit them. This fixes that.
#27084 prevents this from happening again.
All I did was run
cd ghost/core && yarn test:e2e. I don't really know what this snapshot is about.