Removed unused "destroy automated email" endpoint

[EvanHahn]

closes https://linear.app/ghost/issue/NY-1201

We aren't using this endpoint today, and its existence makes a future change more difficult. Let's remove it.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0352b8e7-3bbb-45ef-9b29-b214f0df9177

📥 Commits

Reviewing files that changed from the base of the PR and between 93f5831 and 458f574.

⛔ Files ignored due to path filters (1)

• ghost/core/test/e2e-api/admin/__snapshots__/automated-emails.test.js.snap is excluded by !**/*.snap

📒 Files selected for processing (3)

• ghost/core/core/server/api/endpoints/automated-emails.js
• ghost/core/core/server/web/api/endpoints/admin/routes.js
• ghost/core/test/e2e-api/admin/automated-emails.test.js

💤 Files with no reviewable changes (3)

• ghost/core/core/server/web/api/endpoints/admin/routes.js
• ghost/core/test/e2e-api/admin/automated-emails.test.js
• ghost/core/core/server/api/endpoints/automated-emails.js

---

Walkthrough

This change removes the DELETE endpoint for automated emails from the system. The modifications include: removing the destroy endpoint handler from the automated emails controller, removing the corresponding DELETE /automated_emails/:id route from the admin REST API routes, and removing the associated destroy test cases from the e2e test suite. The remaining automated email operations (browse, read, add, edit, and sendTestEmail) remain unchanged and functional.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely describes the main change: removing the unused destroy automated email endpoint.
Description check	✅ Passed	The description is directly related to the changeset, explaining why the endpoint is being removed and referencing the associated issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch evanhahn-ny-1201-remove-destroy-automated-emails-endpoint

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[troyciesco]

lgtm - just noting we still have the "delete automated emails" permission in ghost/core/core/server/data/schema/fixtures/fixtures.json, but i think we still want that based on the other work you're doing.

[EvanHahn]

Didn't know about that...thank you!