Skip to content

Dropped automated_emails table#27186

Merged
EvanHahn merged 5 commits intomainfrom
NY-1188-part-4
Apr 8, 2026
Merged

Dropped automated_emails table#27186
EvanHahn merged 5 commits intomainfrom
NY-1188-part-4

Conversation

@EvanHahn
Copy link
Copy Markdown
Contributor

@EvanHahn EvanHahn commented Apr 6, 2026

closes https://linear.app/ghost/issue/NY-1188
ref #27185

This removes the old automated emails table now that we aren't using it anymore.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f488bd97-b45e-48c5-b334-88a4cd3c3d56

📥 Commits

Reviewing files that changed from the base of the PR and between 88cedbe and a41dcea.

📒 Files selected for processing (2)
  • ghost/core/core/server/data/migrations/versions/6.28/2026-04-08-13-05-35-drop-automated-emails-table.js
  • ghost/core/core/server/data/schema/schema.js
💤 Files with no reviewable changes (1)
  • ghost/core/core/server/data/schema/schema.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • ghost/core/core/server/data/migrations/versions/6.28/2026-04-08-13-05-35-drop-automated-emails-table.js

Walkthrough

The changes remove the automated_emails table from the codebase and exports: the table definition is deleted from the schema, and automated_emails is removed from the backup/export table list. A new non-transactional migration is added to drop automated_emails on up and recreate it on down using a stored schema spec. Tests and the schema-integrity hash are updated to reflect the schema change.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: removing the automated_emails table from the database schema.
Description check ✅ Passed The description is directly related to the changeset, explaining that the old automated_emails table is being removed because it is no longer used.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch NY-1188-part-4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the migration [pull request] Includes migration for review label Apr 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

It looks like this PR contains a migration 👀
Here's the checklist for reviewing migrations:

General requirements

  • ⚠️ Tested performance on staging database servers, as performance on local machines is not comparable to a production environment
  • Satisfies idempotency requirement (both up() and down())
  • Does not reference models
  • Filename is in the correct format (and correctly ordered)
  • Targets the next minor version
  • All code paths have appropriate log messages
  • Uses the correct utils
  • Contains a minimal changeset
  • Does not mix DDL/DML operations
  • Tested in MySQL and SQLite

Schema changes

  • Both schema change and related migration have been implemented
  • For index changes: has been performance tested for large tables
  • For new tables/columns: fields use the appropriate predefined field lengths
  • For new tables/columns: field names follow the appropriate conventions
  • Does not drop a non-alpha table outside of a major version

Data changes

  • Mass updates/inserts are batched appropriately
  • Does not loop over large tables/datasets
  • Defends against missing or invalid data
  • For settings updates: follows the appropriate guidelines

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@EvanHahn EvanHahn force-pushed the NY-1188-part-4 branch 2 times, most recently from f3b68b2 to 1ccf85b Compare April 6, 2026 19:47
@EvanHahn EvanHahn marked this pull request as ready for review April 6, 2026 19:47
@EvanHahn EvanHahn requested a review from cmraible April 6, 2026 19:47
Copy link
Copy Markdown
Collaborator

@cmraible cmraible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion on the migration, otherwise LGTM!

@EvanHahn
Copy link
Copy Markdown
Contributor Author

EvanHahn commented Apr 7, 2026

Moving this to draft until #27185 is merged. I'll regenerate the migration and address the PR review comment.

Base automatically changed from NY-1188-part-3 to main April 8, 2026 01:15
@EvanHahn EvanHahn enabled auto-merge (squash) April 8, 2026 13:19
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2026

@EvanHahn EvanHahn merged commit caf0b88 into main Apr 8, 2026
39 checks passed
@EvanHahn EvanHahn deleted the NY-1188-part-4 branch April 8, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration [pull request] Includes migration for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants