Remove dead Ember members list code#27218
Remove dead Ember members list code#27218jonatansberg wants to merge 17 commits intober-3361-remove-feature-flag-releasefrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 24122314149 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release This releases the React-owned /members routes while keeping Ember detail flows intact and deferring dead-code cleanup to the next stacked PR.
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release This aligns the import-route unit coverage with the released behavior after removing the members-forward flag.
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release This drops the extra routes test file so the release branch stays focused on the shipped members routing change.
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release The config and runtime changes already cover the flag removal, so this extra assertion only added noise to the branch.
f801bc0 to
7fbc6a7
Compare
5500cdf to
a0360a2
Compare
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 24124255395 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release Reused the shared link active matcher for the React-owned members routes and dropped the bespoke pathname check.
a0360a2 to
e8f4eb5
Compare
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 24127467123 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release The release branch moved /members out of the Ember test lane, so the auth acceptance tests now use an Ember-owned protected route and the analytics assertion matches the released React copy.
e8f4eb5 to
a40fe8d
Compare
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 24129112549 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release The old filter-actions Playwright spec still drove Ember-only members filter controls that no longer exist on the released React /members route, while equivalent bulk-label coverage already exists in the React members suite.
a40fe8d to
ee528f0
Compare
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release These Playwright tests still asserted the old Ember members list surface even though /members is now React-owned, and the retained Ember detail flows are covered by the remaining detail-focused specs.
ee528f0 to
42bb573
Compare
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 24181951045 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release Row clicks on the React members list were bypassing the back query string even though the rendered links already carried it. This shares one detail-hash builder between link and row navigation so retained Ember detail screens can return to the filtered list state.
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release The release branch still ran Ember-list import and export coverage even though those routes are no longer part of the shipped members list. This drops the dead import spec and keeps the export coverage focused on the React-owned members route.
42bb573 to
63fc698
Compare
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release Removed redundant nav wiring, simplified the member detail path helper naming, and dropped the stale members-route e2e case without changing runtime behavior.
e195939 to
f2d6660
Compare
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release Migrated the dropped React import flow and retained legacy member-detail coverage, and tightened bulk-action coverage so the filtered-members behavior still has an active browser test.
f2d6660 to
cab753a
Compare
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 24190435147 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release Updated the Playwright import modal helper to match the shipped React import dialog instead of the old Ember data-test selectors so the restored browser coverage exercises the real UI.
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release Prepared the remaining codepaths and tests for the dead Ember members surface removal.
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release Dropped the unreachable Ember members list, import, filter, and legacy test files after the route handoff.
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release Kept the Ember member detail flow working after the list cleanup by replacing the deleted members controller dependency with direct cache invalidation.
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release The cleanup branch no longer needs the state-bridge comment and test rewrites that were introduced while removing the Ember members list. Reverting them removes duplicated test blocks and clears the Sonar duplication gate without changing runtime behavior.
cab753a to
cef67b2
Compare
|
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 24191569792 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
6b3b0a0 to
604331b
Compare



Summary
This PR is stacked on top of
ber-3361-remove-feature-flag-releaseand should be reviewed against that base branch.It removes the dead Ember members list, import, and filter implementation that became unreachable once BER-3361 moved
/membersand/members/importto the React app.What changed
Why
The lower BER-3361 stacked PR handles the release behavior change and feature-flag removal. This follow-up keeps that review isolated by deleting the now-dead Ember implementation separately.
Testing
YARN_IGNORE_ENGINES=1 yarn workspace @tryghost/e2e test:typesyarn --cwd e2e eslint helpers/pages/admin/members/index.ts tests/admin/members/export.test.tsYARN_IGNORE_ENGINES=1 yarn --cwd ghost/admin eslint app/helpers/reset-query-params.js app/services/state-bridge.js tests/unit/services/state-bridge-test.jscd ghost/admin && YARN_IGNORE_ENGINES=1 yarn lint:hbs app/templates app/componentsYARN_IGNORE_ENGINES=1 yarn workspace @tryghost/admin test:unit src/members-route.test.tsxYARN_IGNORE_ENGINES=1 yarn workspace @tryghost/posts exec vitest run test/unit/views/members/members-actions.test.tsx