Skip to content

Fixed serif font in welcome email previews#27223

Merged
weylandswart merged 1 commit intomainfrom
weyland-des-1309-welcome-emails-body-font-regression
Apr 8, 2026
Merged

Fixed serif font in welcome email previews#27223
weylandswart merged 1 commit intomainfrom
weyland-des-1309-welcome-emails-body-font-regression

Conversation

@weylandswart
Copy link
Copy Markdown
Contributor

Closes https://linear.app/ghost/issue/DES-1309/welcome-emails-body-font-regression

Koenig's styles were winning the specificity battle here.

Before After
Screenshot 2026-04-08 at 09 41 11 Screenshot 2026-04-08 at 09 40 54

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 68096414-67ce-44e2-aff7-3f216b5c3140

📥 Commits

Reviewing files that changed from the base of the PR and between 815962d and 454c639.

📒 Files selected for processing (1)
  • apps/admin-x-settings/src/components/settings/membership/member-emails/member-email-editor.tsx

Walkthrough

This change modifies the member email editor component to update CSS utility selectors for typography in Koenig content. Specifically, the font styling for placeholder text and body elements including paragraphs, blockquotes, asides, and list items has been switched from font-inter to font-sans!. The same adjustment applies to nested editor placeholder and content within the .not-kg-prose>div selector. The modification is purely CSS-based with no changes to component logic, props, rendering structure, or event handling.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing serif font rendering in welcome email previews, which matches the changeset's CSS update to enforce sans-serif typography.
Description check ✅ Passed The description is directly related to the changeset, explaining the font regression issue and including before/after screenshots demonstrating the fix from serif to sans-serif typography.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch weyland-des-1309-welcome-emails-body-font-regression

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2026

@weylandswart weylandswart merged commit ca0c181 into main Apr 8, 2026
38 checks passed
@weylandswart weylandswart deleted the weyland-des-1309-welcome-emails-body-font-regression branch April 8, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant