Skip to content

Removed top divider from welcome email customization preview#27225

Merged
troyciesco merged 1 commit into
mainfrom
NY-1211_rm-extra-hr
Apr 8, 2026
Merged

Removed top divider from welcome email customization preview#27225
troyciesco merged 1 commit into
mainfrom
NY-1211_rm-extra-hr

Conversation

@troyciesco
Copy link
Copy Markdown
Contributor

@troyciesco troyciesco commented Apr 8, 2026

closes NY-1211

  • removes top divider from welcome email preview, because it was kind of confusing - it seemed like it was part of the header
  • there are still other dividers in the preview to be able to see changes to divider color
  • also cleans up a class that could be text-body-sm instead of text-[1.3rem]

before:
Screenshot 2026-04-08 at 8 06 54 AM

after
Screenshot 2026-04-08 at 8 07 17 AM

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 49d40a7d-1412-4b17-a444-eda4fc79a0b0

📥 Commits

Reviewing files that changed from the base of the PR and between afcabc6 and ab8107e.

📒 Files selected for processing (1)
  • apps/admin-x-settings/src/components/settings/email-design/welcome-email-preview-content.tsx

Walkthrough

The welcome email preview content component was updated with layout and styling adjustments. Padding was added to the top-level container via a pt-16 class addition. The divider element was repositioned to appear after the main body content and image caption, rather than at the top of the return section. The image caption styling was changed from using an explicit size value to using a theme token. The divider styling itself remained unchanged. No modifications were made to exported or public entities.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch NY-1211_rm-extra-hr

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 8, 2026

@troyciesco troyciesco enabled auto-merge (squash) April 8, 2026 12:28
@troyciesco troyciesco merged commit f73498c into main Apr 8, 2026
38 checks passed
@troyciesco troyciesco deleted the NY-1211_rm-extra-hr branch April 8, 2026 12:42
franky19 pushed a commit to franky19/Ghost that referenced this pull request Apr 18, 2026
…t#27225)

closes
[NY-1211](https://linear.app/ghost/issue/NY-1211/remove-separator-from-welcome-email-header)

- removes top divider from welcome email preview, because it was kind of
confusing - it seemed like it was part of the header
- there are still other dividers in the preview to be able to see
changes to divider color
- also cleans up a class that could be `text-body-sm` instead of
`text-[1.3rem]`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant