Split TryGhost package updates into smaller groups#27233
Merged
Conversation
The shared Renovate preset groups many internal @TryGhost packages into a single broad PR. In practice that has made failures hard to diagnose: rendering and email changes, admin-facing utility updates, runtime plumbing, and test support packages all land together and a failure in one area blocks the rest. Split those internal packages into smaller non-overlapping groups so we can work through them independently. This should make it much easier to reopen and validate one logical lane at a time instead of carrying a single noisy tryghost-packages PR.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe change adds four new package rules to the Renovate configuration file. These rules organize TryGhost scoped packages into separate groupings: runtime packages, admin support packages, content and email packages, and test support packages. Each rule specifies a group name and a list of package names to match. No existing configuration rules were modified or removed. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/renovate.json5:
- Around line 110-175: Move the entry "@tryghost/email-mock-receiver" out of the
"TryGhost runtime packages" matchPackageNames array and add it to the "TryGhost
test support packages" matchPackageNames array so it is grouped with
"@tryghost/webhook-mock-receiver" and "@tryghost/express-test"; also check the
package's declaration in package.json (currently listed in dependencies) and
confirm whether it should be a devDependency before finalizing the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f424ef3c-dc78-41f7-917b-05f34a4b0206
📒 Files selected for processing (1)
.github/renovate.json5
CodeRabbit pointed out that @tryghost/email-mock-receiver is only referenced from ghost/core test helpers, so grouping it with the runtime lane makes the internal package split less representative of how Ghost actually uses it. Move it into the test support group alongside the other test-only TryGhost helpers. The package still lives in ghost/core dependencies today, so this change only adjusts the Renovate grouping, not the package declaration itself.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27233 +/- ##
==========================================
+ Coverage 73.42% 73.45% +0.02%
==========================================
Files 1545 1545
Lines 123643 123642 -1
Branches 14948 14954 +6
==========================================
+ Hits 90790 90822 +32
+ Misses 31832 31822 -10
+ Partials 1021 998 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
franky19
pushed a commit
to franky19/Ghost
that referenced
this pull request
Apr 18, 2026
…host#27233) The shared Renovate preset groups many internal @TryGhost packages into a single broad PR. In practice that has made failures hard to diagnose: rendering and email changes, admin-facing utility updates, runtime plumbing, and test support packages all land together and a failure in one area blocks the rest. Split those internal packages into smaller non-overlapping groups so we can work through them independently. This should make it much easier to reopen and validate one logical lane at a time instead of carrying a single noisy tryghost-packages PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@tryghost/*update group into smaller non-overlapping groups in Ghost's local Renovate config@tryghost/*update PRs easier to diagnose and merge incrementallyWhy this change
The current shared
tryghost-packagesgroup is too broad to debug efficiently. Recent failures mixed together email rendering changes, admin-facing utility updates, runtime plumbing, and test support packages, so a failure in one area blocked all of the others.Splitting the internal package updates into smaller logical lanes should let Ghost reopen and validate one subset at a time instead of carrying a single noisy grouped PR.