Added support for publication icon in the welcome emails renderer

[cmraible]

closes https://linear.app/ghost/issue/NY-1214/

This wires up the welcome email renderer to conditionally include the site's publication icon in the header. If the publication icon exists, and the show_header_icon email design setting is enabled, it will render the publication icon in the welcome emails.

This only updates the renderer; a forthcoming PR will add the toggle to the customize modal.

If you'd rather listen to this PR:

PR.27268.mp4

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cb2e130b-09fe-414b-b7f0-11a75d76853f

📥 Commits

Reviewing files that changed from the base of the PR and between 1b35519 and 17d5dbc.

📒 Files selected for processing (3)

• ghost/core/core/server/services/member-welcome-emails/member-welcome-email-renderer.js
• ghost/core/core/server/services/member-welcome-emails/service.js
• ghost/core/test/unit/server/services/member-welcome-emails/member-welcome-email-renderer.test.js

✅ Files skipped from review due to trivial changes (2)

• ghost/core/core/server/services/member-welcome-emails/service.js
• ghost/core/test/unit/server/services/member-welcome-emails/member-welcome-email-renderer.test.js

---

Walkthrough

The pull request makes member welcome emails aware of a publication icon. The renderer computes showHeaderIcon (true only if designSettings.show_header_icon is not false and siteSettings.iconUrl is truthy), includes showHeaderIcon in the template context, and updates hasHeaderContent to account for the icon. The service's #getSiteSettings() now reads icon from settings and exposes iconUrl (via urlUtils.urlFor('image', {image: icon}, true) or null). Tests add an iconUrl fixture value and three cases covering enabled/disabled/missing icon scenarios.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: adding support for publication icons in welcome email rendering, which directly corresponds to the changeset modifications.
Description check	✅ Passed	The description is directly related to the changeset, explaining the feature (conditionally rendering publication icons in welcome emails based on settings) and implementation scope.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chris-ny-1214-support-publication-icon-in-the-email-renderer

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cmraible]

@CodeRabbit review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[sonarqubecloud]

Quality Gate failed

Failed conditions
15.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud