Skip to content

Added gift member status filter in admin#27294

Merged
mike182uk merged 1 commit intomainfrom
BER-3481-add-gift-member-filter-status
Apr 13, 2026
Merged

Added gift member status filter in admin#27294
mike182uk merged 1 commit intomainfrom
BER-3481-add-gift-member-filter-status

Conversation

@mike182uk
Copy link
Copy Markdown
Member

ref https://linear.app/ghost/issue/BER-3481

Added gift member status filter in admin to allow filtering members who have a gift subscription

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 775d691f-ad38-44a7-a723-fd01672ceaf0

📥 Commits

Reviewing files that changed from the base of the PR and between 53a6fdb and d782ff4.

📒 Files selected for processing (6)
  • apps/admin-x-framework/src/api/members.ts
  • apps/posts/src/views/members/components/members-filters.tsx
  • apps/posts/src/views/members/components/members-list-item.tsx
  • apps/posts/src/views/members/use-member-filter-fields.test.ts
  • apps/posts/src/views/members/use-member-filter-fields.ts
  • ghost/admin/app/components/members/filters/status.js
✅ Files skipped from review due to trivial changes (1)
  • apps/posts/src/views/members/components/members-filters.tsx
🚧 Files skipped from review as they are similar to previous changes (5)
  • apps/posts/src/views/members/components/members-list-item.tsx
  • apps/posts/src/views/members/use-member-filter-fields.test.ts
  • ghost/admin/app/components/members/filters/status.js
  • apps/admin-x-framework/src/api/members.ts
  • apps/posts/src/views/members/use-member-filter-fields.ts

Walkthrough

This pull request adds support for a new 'gift' member subscription status across the codebase. Changes include updating the Member type to include the new status literal, modifying member filter components to accept a giftSubscriptionsEnabled configuration flag sourced from lab configuration, updating the member list UI to display the gift status label, and conditionally adding gift as a filter option when the feature is enabled. Tests are added to verify the gift status filtering behavior.

Possibly related PRs

  • Added gift to member status #26992 - Updates core schema validation enums to allow the 'gift' status, complementing the TypeScript type and UI/filter logic changes in this PR

Suggested reviewers

  • sagzy
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding a gift member status filter in the admin interface for filtering members with gift subscriptions.
Description check ✅ Passed The description clearly explains the purpose and scope of the changes: adding a gift member status filter to allow filtering members with gift subscriptions, and references the related issue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch BER-3481-add-gift-member-filter-status

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@mike182uk mike182uk force-pushed the BER-3481-add-gift-member-filter-status branch from 4fbac20 to 53a6fdb Compare April 9, 2026 20:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 24211791713 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

ref https://linear.app/ghost/issue/BER-3481

Added gift member status filter in admin to allow filtering members who
have a gift subscription
@mike182uk mike182uk force-pushed the BER-3481-add-gift-member-filter-status branch from 53a6fdb to d782ff4 Compare April 13, 2026 09:05
@sonarqubecloud
Copy link
Copy Markdown

@mike182uk mike182uk merged commit 7796301 into main Apr 13, 2026
41 checks passed
@mike182uk mike182uk deleted the BER-3481-add-gift-member-filter-status branch April 13, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants