Skip to content

✨ Added design customization options for welcome emails#27313

Merged
cmraible merged 2 commits intomainfrom
chris-promote-welcome-emails-customization-to-ga
Apr 13, 2026
Merged

✨ Added design customization options for welcome emails#27313
cmraible merged 2 commits intomainfrom
chris-promote-welcome-emails-customization-to-ga

Conversation

@cmraible
Copy link
Copy Markdown
Collaborator

@cmraible cmraible commented Apr 9, 2026

The functionality is already live on main behind the labs flag; this change just promotes the flag to GA so welcome emails customization will be enabled by default.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9edafc80-7abe-481f-96fa-f51172810c11

📥 Commits

Reviewing files that changed from the base of the PR and between 8b4ecc4 and 5cd6061.

⛔ Files ignored due to path filters (1)
  • ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • ghost/core/core/shared/labs.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • ghost/core/core/shared/labs.js

Walkthrough

The welcomeEmailsDesignCustomization feature flag was moved from the PRIVATE_FEATURES set to the GA_FEATURES set in ghost/core/core/shared/labs.js. As a result, GA_KEYS now includes the flag, WRITABLE_KEYS_ALLOWLIST no longer lists it under private features, and getAllFlags() reports the flag in the GA portion rather than the private portion.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes adding design customization for welcome emails, but the actual change is promoting an existing labs flag to GA, not adding new functionality. Consider revising the title to reflect the actual change, such as 'Promote welcome emails design customization to GA' or 'Make welcome emails customization generally available'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains that the functionality is already live and this change promotes the flag to GA, which accurately relates to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chris-promote-welcome-emails-customization-to-ga

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cmraible cmraible marked this pull request as ready for review April 9, 2026 17:13
@cmraible cmraible marked this pull request as draft April 9, 2026 17:55
@cmraible
Copy link
Copy Markdown
Collaborator Author

cmraible commented Apr 9, 2026

Reverting to draft, as we've decided to wait on this until Monday

@cmraible cmraible marked this pull request as ready for review April 13, 2026 16:50
@cmraible cmraible requested a review from troyciesco April 13, 2026 16:50
@cmraible cmraible force-pushed the chris-promote-welcome-emails-customization-to-ga branch from 8b4ecc4 to 5cd6061 Compare April 13, 2026 16:52
@sonarqubecloud
Copy link
Copy Markdown

@cmraible cmraible merged commit 6fa720e into main Apr 13, 2026
43 checks passed
@cmraible cmraible deleted the chris-promote-welcome-emails-customization-to-ga branch April 13, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants