Skip to content

Fixed image edit and delete buttons being hidden on touch devices#27338

Open
minimaluminium wants to merge 1 commit intomainfrom
image-button-visibility-DES-1341
Open

Fixed image edit and delete buttons being hidden on touch devices#27338
minimaluminium wants to merge 1 commit intomainfrom
image-button-visibility-DES-1341

Conversation

@minimaluminium
Copy link
Copy Markdown
Member

ref https://linear.app/ghost/issue/DES-1341/design-and-branding-ui-issues-on-ios

  • the edit/delete buttons relied on hover to become visible, leaving them inaccessible on touch devices where hover doesn't exist
  • added a [@media(hover:none)]:visible! variant so the buttons are always shown when the device has no hover capability

- the edit/delete buttons relied on hover to become visible, leaving them inaccessible on touch devices where hover doesn't exist
- added a `[@media(hover:none)]:visible!` variant so the buttons are always shown when the device has no hover capability
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6a34c627-1d6b-4756-b1dc-1c6d8a94466e

📥 Commits

Reviewing files that changed from the base of the PR and between 65a1d4a and 0fc5428.

📒 Files selected for processing (1)
  • apps/admin-x-design-system/src/global/form/image-upload.tsx

Walkthrough

This pull request modifies the image upload component in the design system by updating Tailwind CSS class strings on the delete and edit overlay buttons. The changes adjust the visibility behavior of these buttons: they maintain their hidden state on medium screens via the md:invisible class, while adding a media query rule [@media(hover:none)]:visible! to make them explicitly visible on devices without hover capabilities. The modification preserves all existing logic and component props without introducing new functionality or affecting the public API.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: fixing image edit and delete buttons visibility on touch devices.
Description check ✅ Passed The description is directly related to the changeset, explaining the problem (buttons hidden on touch devices), the solution (adding hover:none media query variant), and referencing the related issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch image-button-visibility-DES-1341

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant