Skip to content

Skipped Tinybird tests job on forks#27344

Merged
9larsons merged 1 commit into
mainfrom
fix-tinybird-ci-fork-check
Apr 10, 2026
Merged

Skipped Tinybird tests job on forks#27344
9larsons merged 1 commit into
mainfrom
fix-tinybird-ci-fork-check

Conversation

@9larsons
Copy link
Copy Markdown
Contributor

@9larsons 9larsons commented Apr 10, 2026

no ref

This task requires a secret that's not available on forks, and we should skip it like we do other jobs.

The `if: github.repository == 'TryGhost/Ghost'` condition was always
true for fork PRs because `github.repository` refers to the base repo
in pull_request events. This caused the dispatch step to run without
the required secret, failing the job. The new condition skips the
dispatch step when the PR originates from a fork.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 10, 2026

Walkthrough

The conditional logic for a Tinybird workflow step in the CI pipeline was modified. Previously, the step ran only when the repository matched a specific value. The new logic allows the step to execute for all non-pull-request events, while for pull-request events, it runs only when the PR's head repository matches the current repository. This change adjusts when the traffic analytics infrastructure workflow is triggered during the CI process.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: skipping the Tinybird tests job on forks, which is the core issue being fixed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description briefly mentions the issue and solution, relating directly to the changeset which fixes a Tinybird CI dispatch step conditional for fork PRs.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-tinybird-ci-fork-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@9larsons 9larsons changed the title 🐛 Fixed Tinybird CI dispatch step failing on fork PRs Skipped Tinybird tests job on forks Apr 10, 2026
@9larsons 9larsons enabled auto-merge (squash) April 10, 2026 22:05
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.46%. Comparing base (17b5b5a) to head (adff9c7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #27344   +/-   ##
=======================================
  Coverage   73.46%   73.46%           
=======================================
  Files        1545     1545           
  Lines      123724   123724           
  Branches    14970    14970           
=======================================
+ Hits        90893    90894    +1     
- Misses      31808    31828   +20     
+ Partials     1023     1002   -21     
Flag Coverage Δ
admin-tests 54.36% <ø> (+<0.01%) ⬆️
e2e-tests 73.46% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@9larsons 9larsons merged commit 32d4230 into main Apr 10, 2026
46 checks passed
@9larsons 9larsons deleted the fix-tinybird-ci-fork-check branch April 10, 2026 22:28
franky19 pushed a commit to franky19/Ghost that referenced this pull request Apr 18, 2026
no ref

This task requires a secret that's not available on forks, and we should
skip it like we do other jobs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants