Included CI-relevant paths in nx.json named inputs#27349
Included CI-relevant paths in nx.json named inputs#27349acburdine wants to merge 1 commit intoTryGhost:mainfrom
Conversation
no issue Adds filepaths for shared ci/other flows to default nx named inputs. This allows us to remove the dependency on the 'shared' filepath detection in the ci paths-filter and exclusively leverage nx affected to determine if builds should run
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
I also looked into whether it's possible to have a separate set of "named inputs" that are only taken into account in CI, but unfortunately it looks like the |
|
hmm actually I think I can take the approach I did initially in #27202 and it'll work better than adding all of the github ci files to named inputs |



Summary
Adds filepaths for shared ci/other flows to default nx named inputs. This allows us to remove the dependency on the 'shared' filepath detection in the ci paths-filter and exclusively leverage nx affected to determine if builds should run
Why
Relates to #27348 - once we start to use
nx affectedto conditionally skip/trigger jobs, we will need some way to dictate tonxthat changes to the.github/folder should trigger reruns of packages in the workspace. Instead of looking at changes in all.githubfiles however, I borrowed the list of relevant files from #27311 so things are a bit cleaner.Potential Drawbacks
Because nx.json affects local development as well as CI runs, anytime the Github CI-related files are changed, it will also invalidate the local nx build cache.