Skip to content

Removed gift_subscription_redemption_notification from users table#27369

Merged
mike182uk merged 1 commit intomainfrom
BER-3523-remove-gift-redemption-user-notification
Apr 13, 2026
Merged

Removed gift_subscription_redemption_notification from users table#27369
mike182uk merged 1 commit intomainfrom
BER-3523-remove-gift-redemption-user-notification

Conversation

@mike182uk
Copy link
Copy Markdown
Member

ref https://linear.app/ghost/issue/BER-3523

We decided to remove the email toggle for when a member redeems a gift and instead use the existing new paid members toggle

@github-actions github-actions bot added the migration [pull request] Includes migration for review label Apr 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 13, 2026

It looks like this PR contains a migration 👀
Here's the checklist for reviewing migrations:

General requirements

  • ⚠️ Tested performance on staging database servers, as performance on local machines is not comparable to a production environment
  • Satisfies idempotency requirement (both up() and down())
  • Does not reference models
  • Filename is in the correct format (and correctly ordered)
  • Targets the next minor version
  • All code paths have appropriate log messages
  • Uses the correct utils
  • Contains a minimal changeset
  • Does not mix DDL/DML operations
  • Tested in MySQL and SQLite

Schema changes

  • Both schema change and related migration have been implemented
  • For index changes: has been performance tested for large tables
  • For new tables/columns: fields use the appropriate predefined field lengths
  • For new tables/columns: field names follow the appropriate conventions
  • Does not drop a non-alpha table outside of a major version

Data changes

  • Mass updates/inserts are batched appropriately
  • Does not loop over large tables/datasets
  • Defends against missing or invalid data
  • For settings updates: follows the appropriate guidelines

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d43eebd2-795a-4276-9b81-2a7d663ffbae

📥 Commits

Reviewing files that changed from the base of the PR and between 1c7c021 and df29e39.

⛔ Files ignored due to path filters (7)
  • ghost/core/test/e2e-api/admin/__snapshots__/members.test.js.snap is excluded by !**/*.snap
  • ghost/core/test/e2e-api/admin/__snapshots__/pages.test.js.snap is excluded by !**/*.snap
  • ghost/core/test/e2e-api/admin/__snapshots__/posts.test.js.snap is excluded by !**/*.snap
  • ghost/core/test/e2e-api/admin/__snapshots__/users.test.js.snap is excluded by !**/*.snap
  • ghost/core/test/e2e-webhooks/__snapshots__/pages.test.js.snap is excluded by !**/*.snap
  • ghost/core/test/e2e-webhooks/__snapshots__/posts.test.js.snap is excluded by !**/*.snap
  • ghost/core/test/legacy/api/admin/__snapshots__/authentication.test.js.snap is excluded by !**/*.snap
📒 Files selected for processing (5)
  • ghost/core/core/server/api/endpoints/utils/serializers/output/utils/clean.js
  • ghost/core/core/server/data/migrations/versions/6.29/2026-04-13-09-12-13-drop-gift-subscription-redemption-notification-column.js
  • ghost/core/core/server/data/schema/schema.js
  • ghost/core/core/server/models/user.js
  • ghost/core/test/unit/server/data/schema/integrity.test.js
💤 Files with no reviewable changes (2)
  • ghost/core/core/server/data/schema/schema.js
  • ghost/core/core/server/api/endpoints/utils/serializers/output/utils/clean.js
✅ Files skipped from review due to trivial changes (2)
  • ghost/core/core/server/models/user.js
  • ghost/core/test/unit/server/data/schema/integrity.test.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • ghost/core/core/server/data/migrations/versions/6.29/2026-04-13-09-12-13-drop-gift-subscription-redemption-notification-column.js

Walkthrough

Removed the gift_subscription_redemption_notification field: it was deleted from the users table schema and from User model defaults, and a migration was added to drop the column. The DB schema integrity test hash was updated to reflect the change. Separately, the Content API serializer’s author path no longer deletes gift_subscription_redemption_notification, allowing that attribute to persist in serialized author output for Content API frames.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly matches the main change: removing the gift_subscription_redemption_notification column from the users table.
Description check ✅ Passed The description is related to the changeset, referencing the Linear issue and explaining the business rationale for removing the column.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch BER-3523-remove-gift-redemption-user-notification

Comment @coderabbitai help to get the list of available commands and usage tips.

@mike182uk mike182uk force-pushed the BER-3523-remove-gift-redemption-user-notification branch from ee52d6b to 1c7c021 Compare April 13, 2026 09:35
ref https://linear.app/ghost/issue/BER-3523

We decided to remove the email toggle for when a member redeems a gift and
instead use the existing `new paid members` toggle
@mike182uk mike182uk force-pushed the BER-3523-remove-gift-redemption-user-notification branch from 1c7c021 to df29e39 Compare April 13, 2026 10:02
@sonarqubecloud
Copy link
Copy Markdown

@mike182uk mike182uk merged commit e2fca76 into main Apr 13, 2026
43 checks passed
@mike182uk mike182uk deleted the BER-3523-remove-gift-redemption-user-notification branch April 13, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration [pull request] Includes migration for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants