Fixed flaky test for welcome email customization

[troyciesco]

ref https://github.com/TryGhost/Ghost/actions/runs/24453350917/job/71449353776

Changes

• Updated Escape closes welcome email color picker without bypassing unsaved changes confirmation in e2e/tests/admin/settings/member-welcome-emails.test.ts.
• Replaced implicit dirty-state setup with a deterministic color-change sequence:
  • open picker
  • click Accent
  • reopen picker
  • click Auto
• Kept Escape assertions unchanged:
  • first Escape closes only the color picker
  • second Escape shows unsaved-changes confirmation and keeps the customize modal open

Why

The test was intermittent because dirty state was not always guaranteed before Escape.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7942fe5e-9b7e-4ff9-a40d-d781314c7707

📥 Commits

Reviewing files that changed from the base of the PR and between ee4ec2d and 621d4a4.

📒 Files selected for processing (2)

• e2e/helpers/pages/admin/settings/sections/member-welcome-emails-section.ts
• e2e/tests/admin/settings/member-welcome-emails.test.ts

✅ Files skipped from review due to trivial changes (1)

• e2e/helpers/pages/admin/settings/sections/member-welcome-emails-section.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• e2e/tests/admin/settings/member-welcome-emails.test.ts

---

Walkthrough

A test in the member welcome email settings was modified to extend the color-picker interaction sequence. After selecting an accent color swatch, the test now reopens the button color-picker trigger and clicks the role-labeled "Auto" color option within the customization modal before continuing with the existing flow. Two locator/property additions were made to support this additional interaction.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: fixing a flaky test for welcome email customization by making its dirty-state setup deterministic.
Description check	✅ Passed	The description clearly explains what changed, why it changed, and provides specific details about the deterministic color-change sequence and Escape-key assertions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-flaky-welcome-email-test-260415

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud