Removed "member not found" option from welcome email automation runs

[EvanHahn]

closes https://linear.app/ghost/issue/NY-1192
ref #27456

Turns out that this value will never be set because of cascade deletions. Let's drop the option.

[coderabbitai]

Walkthrough

This pull request removes 'member not found' as a valid exit reason value from the welcome email automation runs feature. The change updates the schema validation constraints for the exit_reason column in the welcome_email_automation_runs table to exclude this value, retaining only 'email send failed', 'member unsubscribed', 'member changed status', and 'finished'. Correspondingly, the JSDoc type signature for the markExited() function in the poll service is updated to reflect the narrowed set of allowed exit reason values, maintaining consistency between the schema and service layer documentation.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and clearly describes the main change: removing 'member not found' from welcome email automation run exit reasons.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The pull request description directly relates to the changeset by explaining the reason for removing 'member not found' from the exit_reason validation enum and JSDoc signature.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch remove-unused-automation-run-exit-reason

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[EvanHahn]

Theoretically, we should create a database migration to drop these rows.

Practically, no such rows should exit. We never had code to create them, and any relevant code is development-only right now.

(The original migration mentioned this value and I don't think we need to drop it. In other words, I don't think these validations got encoded into the schema.)

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@ghost/core/core/server/data/schema/schema.js`:
- Line 1202: Update the 6.29 migration that sets the newsletters table/column
validation for exit_reason so its validations.isIn array matches the runtime
schema: remove the "member not found" entry from the exit_reason allowed values
(the same field referenced as exit_reason with validations.isIn), ensuring the
migration's enum/list no longer contains that value and preserving the other
values ("email send failed", "member unsubscribed", "member changed status",
"finished").

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 81abc2e2-8619-4f33-b5cc-271619d418f6

📥 Commits

Reviewing files that changed from the base of the PR and between 3a030fd and 73fc594.

📒 Files selected for processing (2)

• ghost/core/core/server/data/schema/schema.js
• ghost/core/core/server/services/welcome-email-automations/poll.js

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud