Removed feature flag for welcome email design customization

[EvanHahn]

closes https://linear.app/ghost/issue/NY-1224

I recommend reviewing this with whitespace changes disabled.

We've released the feature so we can delete this flag.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 38111dd1-b27f-4099-ad81-a6d984fcd335

📥 Commits

Reviewing files that changed from the base of the PR and between d225031 and ac5abdb.

⛔ Files ignored due to path filters (3)

• ghost/core/test/e2e-api/admin/__snapshots__/config.test.js.snap is excluded by !**/*.snap
• ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap is excluded by !**/*.snap
• ghost/core/test/integration/services/__snapshots__/member-welcome-emails-snapshot.test.js.snap is excluded by !**/*.snap

📒 Files selected for processing (10)

• apps/admin-x-settings/src/components/settings/advanced/labs/private-features.tsx
• apps/admin-x-settings/src/components/settings/membership/member-emails.tsx
• apps/admin-x-settings/test/acceptance/membership/member-welcome-emails.test.ts
• e2e/tests/admin/settings/member-welcome-emails.test.ts
• ghost/core/core/server/services/member-welcome-emails/member-welcome-email-renderer.js
• ghost/core/core/server/services/member-welcome-emails/service.js
• ghost/core/core/shared/labs.js
• ghost/core/test/integration/services/member-welcome-emails-snapshot.test.js
• ghost/core/test/integration/services/member-welcome-emails.test.js
• ghost/core/test/unit/server/services/member-welcome-emails/member-welcome-email-renderer.test.js

💤 Files with no reviewable changes (2)

• apps/admin-x-settings/src/components/settings/advanced/labs/private-features.tsx
• ghost/core/test/integration/services/member-welcome-emails-snapshot.test.js

✅ Files skipped from review due to trivial changes (1)

• apps/admin-x-settings/src/components/settings/membership/member-emails.tsx

🚧 Files skipped from review as they are similar to previous changes (5)

• ghost/core/test/integration/services/member-welcome-emails.test.js
• e2e/tests/admin/settings/member-welcome-emails.test.ts
• ghost/core/test/unit/server/services/member-welcome-emails/member-welcome-email-renderer.test.js
• ghost/core/core/shared/labs.js
• apps/admin-x-settings/test/acceptance/membership/member-welcome-emails.test.ts

---

Walkthrough

The pull request removes the welcomeEmailsDesignCustomization labs flag across the codebase. Admin UI entries and conditional rendering for that flag were deleted so the Customize button and modal are always available. Server-side service and renderer code no longer branch on the flag and always load and use email design settings and helpers/partials. The flag was removed from the GA features allowlist. Tests and e2e suites were simplified: fixtures and stubs referencing the flag were removed, flag-specific test cases were deleted or consolidated, and snapshot/unit/integration tests no longer toggle or assert behavior based on the labs flag.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: removing the feature flag for welcome email design customization, which is directly reflected across all modified files.
Description check	✅ Passed	The description is directly related to the changeset, explaining that the feature has been released and thus the flag can be deleted, which aligns with the comprehensive removal of the feature flag across the codebase.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch NY-1224

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud