Skip to content

Removed unused ESLint disable in navigation editor hook#27497

Merged
EvanHahn merged 1 commit into
mainfrom
remove-unused-eslint-disable-next-line
Apr 21, 2026
Merged

Removed unused ESLint disable in navigation editor hook#27497
EvanHahn merged 1 commit into
mainfrom
remove-unused-eslint-disable-next-line

Conversation

@EvanHahn
Copy link
Copy Markdown
Contributor

no ref

Spotted this useless suppression while working on something else.

no ref

Spotted this useless suppression while working on something else.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7c38ffb5-4894-4c8b-8b3e-32b7ede08388

📥 Commits

Reviewing files that changed from the base of the PR and between 182b934 and e35481c.

📒 Files selected for processing (1)
  • apps/admin-x-settings/src/hooks/site/use-navigation-editor.tsx
💤 Files with no reviewable changes (1)
  • apps/admin-x-settings/src/hooks/site/use-navigation-editor.tsx

Walkthrough

An inline ESLint suppression comment (eslint-disable-next-line no-unused-vars) was removed from the navigation editor hook file, positioned above the exported NavigationItemErrors type. No runtime logic, type definitions, or exported function signatures were modified. The change impacts only the lint directive configuration with a net deletion of one line.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing an unused ESLint disable comment from the navigation editor hook.
Description check ✅ Passed The description relates to the changeset by explaining that an unnecessary ESLint suppression was spotted and removed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-unused-eslint-disable-next-line

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EvanHahn EvanHahn enabled auto-merge (squash) April 21, 2026 21:11
@sonarqubecloud
Copy link
Copy Markdown

@EvanHahn EvanHahn disabled auto-merge April 21, 2026 21:29
@github-actions
Copy link
Copy Markdown
Contributor

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 24746626004 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

@EvanHahn EvanHahn enabled auto-merge (squash) April 21, 2026 21:30
@EvanHahn EvanHahn merged commit f5867c5 into main Apr 21, 2026
71 of 80 checks passed
@EvanHahn EvanHahn deleted the remove-unused-eslint-disable-next-line branch April 21, 2026 21:44
@github-actions
Copy link
Copy Markdown
Contributor

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 24746626004 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant