Skip to content

Revert "Added safety tests for AdapterCacheRedis error and edge-case paths"#27502

Merged
vershwal merged 1 commit into
mainfrom
revert-27479-add-redis-cache-adapter-safety-tests
Apr 22, 2026
Merged

Revert "Added safety tests for AdapterCacheRedis error and edge-case paths"#27502
vershwal merged 1 commit into
mainfrom
revert-27479-add-redis-cache-adapter-safety-tests

Conversation

@vershwal
Copy link
Copy Markdown
Member

Reverts #27479

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 69ccd98b-f195-44b5-bcc3-90dfd116f154

📥 Commits

Reviewing files that changed from the base of the PR and between 19a905f and 2fa3f35.

📒 Files selected for processing (2)
  • ghost/core/test/integration/adapters/redis/adapter-cache-redis.test.js
  • ghost/core/test/unit/server/adapters/lib/redis/adapter-cache-redis.test.js
💤 Files with no reviewable changes (2)
  • ghost/core/test/integration/adapters/redis/adapter-cache-redis.test.js
  • ghost/core/test/unit/server/adapters/lib/redis/adapter-cache-redis.test.js

Walkthrough

This pull request removes test cases from two Redis adapter test files. From the integration test file, 38 lines were deleted, including test cases verifying error handling when fetchData rejects and nested object retrieval. From the unit test file, 143 lines were deleted, removing five test cases that covered error scenarios such as fetchData rejection on cache miss, retry behavior after rejection, Redis operation failures, background refresh errors, and cache.set failures. The remaining tests in both files continue to cover cache hit, cache miss with write-through, timeout behavior, and successful operations.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: reverting a commit that added safety tests for AdapterCacheRedis.
Description check ✅ Passed The description identifies the specific PR being reverted and relates directly to the changeset removing test cases.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-27479-add-redis-cache-adapter-safety-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vershwal vershwal enabled auto-merge (squash) April 22, 2026 10:14
@sonarqubecloud
Copy link
Copy Markdown

@vershwal vershwal merged commit bad043a into main Apr 22, 2026
44 checks passed
@vershwal vershwal deleted the revert-27479-add-redis-cache-adapter-safety-tests branch April 22, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant