Skip to content

Removed useless Comment model test#27540

Merged
EvanHahn merged 1 commit intomainfrom
remove-useless-comment-model-test
Apr 23, 2026
Merged

Removed useless Comment model test#27540
EvanHahn merged 1 commit intomainfrom
remove-useless-comment-model-test

Conversation

@EvanHahn
Copy link
Copy Markdown
Contributor

no ref

This test had no assertions and can easily be removed.

no ref

This test had no assertions and can easily be removed.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4a22d17c-e1d5-40f2-9469-79e5eb3094f2

📥 Commits

Reviewing files that changed from the base of the PR and between f688c77 and 8c43534.

📒 Files selected for processing (1)
  • ghost/core/test/unit/server/models/comment.test.js
💤 Files with no reviewable changes (1)
  • ghost/core/test/unit/server/models/comment.test.js

Walkthrough

The unit test file for the comment model at ghost/core/test/unit/server/models/comment.test.js has been deleted. The file previously contained a test suite definition that performed setup operations for initializing server models and cleanup operations for restoring sinon state after each test. With this deletion, the file no longer contains any test logic or execution code. No public or exported entities were affected by this change.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing a useless/empty Comment model test file with no assertions.
Description check ✅ Passed The description is related to the changeset, explaining that the test had no assertions and could be removed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-useless-comment-model-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EvanHahn EvanHahn enabled auto-merge (squash) April 23, 2026 18:19
@sonarqubecloud
Copy link
Copy Markdown

@EvanHahn EvanHahn merged commit d0650e9 into main Apr 23, 2026
45 checks passed
@EvanHahn EvanHahn deleted the remove-useless-comment-model-test branch April 23, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant