Skip to content

Initialized email address service synchronously#27556

Merged
troyciesco merged 1 commit intomainfrom
fix-promiseall-init-with-email-address-service
Apr 27, 2026
Merged

Initialized email address service synchronously#27556
troyciesco merged 1 commit intomainfrom
fix-promiseall-init-with-email-address-service

Conversation

@EvanHahn
Copy link
Copy Markdown
Contributor

ref #27421 (comment)

emailAddressService.init() was put in a Promise.all unnecessarily. Now it's just a regular function call.

ref #27421 (comment)

`emailAddressService.init()` was put in a `Promise.all` unnecessarily.
Now it's just a regular function call.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ecb7f6cb-57e4-40bb-b9e5-7f90890b0c27

📥 Commits

Reviewing files that changed from the base of the PR and between 405ca7c and 672298c.

📒 Files selected for processing (1)
  • ghost/core/core/boot.js

Walkthrough

The initialization sequence in ghost/core/core/boot.js has been modified to change the order of setup operations. The emailAddressService initialization is now executed immediately before the apiUrl is built, rather than concurrently within the Promise.all block alongside stripe.init(). This adjustment removes emailAddressService from the concurrent initialization group, leaving stripe.init() as the sole remaining operation within that Promise.all, thereby altering the control flow and concurrency pattern between email address and stripe initialization steps.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: moving email address service initialization from Promise.all to synchronous execution.
Description check ✅ Passed The description accurately explains the change, referencing the prior discussion and detailing the shift from Promise.all to regular function call.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-promiseall-init-with-email-address-service

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EvanHahn EvanHahn requested a review from troyciesco April 27, 2026 13:29
@troyciesco troyciesco merged commit cd186f5 into main Apr 27, 2026
43 checks passed
@troyciesco troyciesco deleted the fix-promiseall-init-with-email-address-service branch April 27, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants