Conversation
- The existing moment override pinned 2.24.0, which is itself vulnerable to GHSA-8hfj-j24r-96c4 (high, path traversal in moment.locale, fixed in 2.29.2) and GHSA-wc69-rhjr-hc9g (high, ReDoS, fixed in 2.29.4) - 2.30.1 matches the version apps/comments-ui already declares as a direct dep, so this aligns the override with what one of the public-app callers already wants - Same major; ghost/core (~110 imports) and ghost/admin (~7 imports) both remain on a 2.x API - Verified: pnpm audit drops 49 → 47 unique GHSAs (61 → 59 findings); both moment advisories cleared. pnpm test passes (6283/6283 ghost/core; the comments-ui editor markdown flake reproduces on clean main and is unrelated). pnpm --filter ghost-admin run build exits 0 and run test passes 1079/1079
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThis pull request updates the pinned version of the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27674 +/- ##
=======================================
Coverage 73.19% 73.19%
=======================================
Files 1561 1561
Lines 127072 127072
Branches 15397 15396 -1
=======================================
Hits 93011 93011
- Misses 33082 33102 +20
+ Partials 979 959 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Why
The existing root override pinned
momentat2.24.0, which is itself flagged by two high-severity advisories — path traversal inmoment.locale(GHSA-8hfj-j24r-96c4, fixed in 2.29.2) and ReDoS (GHSA-wc69-rhjr-hc9g, fixed in 2.29.4). The override was therefore actively masking a regression we'd already accepted.2.30.1matches whatapps/comments-uialready declares as a direct dep; pinning the override there means one of our public-app callers gets the version it asked for instead of being force-downgraded. ghost/core (~110 import sites) and ghost/admin (~7 import sites) both remain on the same 2.x API surface, so call-site behavior is unchanged.Test plan
pnpm install— lockfile updates cleanlypnpm audit— 61 → 59 findings, 49 → 47 unique GHSAs; both moment advisories clearedpnpm test— 6283/6283 ghost/core unit tests pass (one pre-existing comments-ui editor markdown flake reproduces on clean main, unrelated)pnpm --filter ghost-admin run build— exit 0pnpm --filter ghost-admin run test— 1079/1079 Ember acceptance/integration tests pass