Conversation
- Existing qs override pinned only ">=6.7.0 <=6.14.1", missing the qs@6.5.5 resolution pulled by request@2.88.2 in the @tryghost/logging chain. That path reaches ghost/core through @tryghost/job-manager, @tryghost/prometheus-metrics, @tryghost/server, gscan, and knex-migrator - GHSA-6rw7-vpxm-498p (mod, arrayLimit DoS, fixed in 6.14.1) covers <6.14.1, so the override range needed widening to match - qs is strict semver and the 6.x line is API-stable; request@2.88.2 works the same against qs@6.14.2 as against 6.5.5 - Verified: pnpm audit drops 46 → 45 unique GHSAs (58 → 57 findings); qs resolves to 6.14.2 / 6.15.0 across the tree, no qs<6.14.1 remains; pnpm test passes 6283/6283 ghost/core (the pre-existing comments-ui editor markdown flake reproduces on clean main and is unrelated)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThe 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27678 +/- ##
=======================================
Coverage 73.19% 73.19%
=======================================
Files 1561 1561
Lines 127072 127072
Branches 15396 15397 +1
=======================================
+ Hits 93011 93012 +1
+ Misses 33082 33081 -1
Partials 979 979
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Why
The existing
qsoverride pinned>=6.7.0 <=6.14.1but missedqs@6.5.5, which reachesghost/coreviarequest@2.88.2 → @tryghost/logging. That logging chain is consumed by@tryghost/job-manager,@tryghost/prometheus-metrics,@tryghost/server,gscan, andknex-migrator— all dependencies ofghost/core, not just an e2e-only path.GHSA-6rw7-vpxm-498p (moderate,
arrayLimitbypass causing DoS via memory exhaustion) is fixed inqs@6.14.1, so the existing override target (^6.14.2) is already correct — only the range needed widening to cover pre-6.7.0 resolutions.qsfollows strict semver and the 6.x line is API-stable, so the deprecatedrequest@2.88.2package works identically againstqs@6.14.2as it did against6.5.5.Test plan
pnpm install— lockfile updates cleanlypnpm audit— total findings 58 → 57, unique GHSAs 46 → 45;qs@6.5.5no longer in the tree, only6.14.2and6.15.0(already patched)pnpm test— 6283/6283 ghost/core unit tests pass (the pre-existing comments-ui editor markdown flake reproduces on clean main and is unrelated)