Conversation
- Newly-published moderate XSS advisory in ip-address's Address6 HTML-emitting methods (Address6.toMicrosoftTransportAddress and similar helpers that produce HTML representations of IPv6 addresses). Affects versions <=10.1.0; fixed in 10.2.0 - Reaches the tree via sqlite3 > node-gyp > make-fetch-happen > socks-proxy-agent > socks > ip-address. That's a build-time chain (sqlite3 native compilation), so the runtime risk surface is limited, but the override is mechanical and the upstream fix is a same-major patch - Verified: pnpm test passes 6283/6283 ghost/core (the comments-ui editor markdown flake reproduces on clean main and is unrelated); ip-address resolves to a single 10.2.0 in the tree
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughA PNPM override was added to 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27688 +/- ##
==========================================
- Coverage 73.19% 73.18% -0.01%
==========================================
Files 1561 1561
Lines 127073 127073
Branches 15395 15394 -1
==========================================
- Hits 93006 93004 -2
- Misses 33110 33111 +1
- Partials 957 958 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Why
A newly-published moderate XSS advisory landed against
ip-address'sAddress6HTML-emitting methods (the helpers that produce HTML representations of IPv6 addresses). Affected versions are<=10.1.0; fixed upstream in10.2.0.In our tree it reaches as
sqlite3 > node-gyp > make-fetch-happen > socks-proxy-agent > socks > ip-address, so it's a build-time chain (sqlite3 native compilation) rather than runtime — the practical risk surface is limited. The override is still worth taking because the fix is a same-major patch and the override is mechanical.Test plan
pnpm install— singleip-address@10.2.0resolution; no change to consumer call sitespnpm audit— closes the moderate ip-address advisory; no new advisories introducedpnpm test— 6283/6283 ghost/core unit tests pass (the pre-existing comments-ui editor markdown flake reproduces on clean main and is unrelated)