Fix comment analytics overview review issues#27758
Draft
jonatansberg wants to merge 7 commits into
Draft
Conversation
- moved the sidebar placement out of CommentsLayout so the page composes the optional analytics sidebar explicitly - kept CommentsLayout as the generic comments page shell and introduced CommentsSidebar for the aside layout classes
- made chart filter clicks apply multiple moderation filters atomically - corrected year-to-date date bounds and hid deltas for ranges without a meaningful comparison - rendered an explicit retry state when the analytics query fails
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft PR stacked on top of
comment-analytics-overview.This addresses review follow-ups for the comment analytics overview:
CommentsLayout,CommentsMain,CommentsSidebar, andCommentsAnalyticshave clearer layout/content boundariesDATE(created_at)Validation
pnpm --filter @tryghost/posts test:unitpnpm --filter @tryghost/posts lint:code(passes with existing unrelateduse-post-success-modal.tswarning)pnpm --dir ghost/core test:single test/integration/services/comments-stats-service.test.jspnpm --dir ghost/core test:single test/e2e-api/admin/stats.test.jsgit diff --check origin/main...HEADNotes
gh auth statusreports an invalid local token, so this PR was created via the GitHub connector after pushing the branch over SSH.