Excluded complimentary members from paid subscription breakdown#27761
Merged
Excluded complimentary members from paid subscription breakdown#27761
Conversation
ref https://linear.app/ghost/issue/BER-3615/ - the "Paid subscriptions" bar chart and "Paid subscription breakdown" pie chart were counting gift redemptions as signups and gift end-of-life events as cancellations, which mixed gift activity into charts that are meant to track paid Stripe activity only - gifts now flow through their own member status (`gift`) and surface in the Paid members KPI tooltip instead, so duplicating them in the per- cadence/per-tier breakdowns double-counted activity and made the bar and pie charts disagree - reverted the gift-aware additions to subscription-stats-service so `/stats/subscriptions` returns paid Stripe deltas and counts only; `gift`→`paid` upgrades still appear via the regular paid subscription event flow once the trial converts and MRR begins
ref https://linear.app/ghost/issue/BER-3614/ ref #27759 - the "Paid subscription breakdown" pie chart was rendering a Complimentary slice derived from the comped delta, which mixed member-status semantics into a chart meant to track paid Stripe subscription activity only - this also caused the pie chart's total to disagree with the "Paid subscriptions" bar chart (which has always been paid-only); with this change the two charts tie out as the issue requires - comp activity is still surfaced in the Paid members KPI tooltip, so no signal is lost for sites that grant complimentary access - removed the now-pointless `calculateStatusSignups` helper that was generalised to support `gift`+`comped` during the gift work but only ever took `'comped'` after gifts moved to the backend
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
sagzy
approved these changes
May 7, 2026
Base automatically changed from
BER-3615-analytics-remove-gift-subs-from-charts
to
main
May 7, 2026 12:32
…move-comped-subs-from-charts # Conflicts: # apps/stats/test/unit/components/growth/new-subscribers-cadence.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/ghost/issue/BER-3614/
ref #27759
calculateStatusSignupshelper that was generalised to supportgift+compedduring the gift work but only ever took'comped'after gifts moved to the backend