Fixed adapter-manager misreporting missing deps as missing adapter#27765
Merged
Conversation
no-issue Node's MODULE_NOT_FOUND errors include a "Require stack" that lists the calling file's path. The existing heuristic checked whether the adapter path appeared anywhere in err.message to distinguish "adapter not found" from "adapter found but has a missing dependency." Because the adapter's own path always appears in the require stack, the check always matched, causing missing-dep errors to be silently swallowed and replaced with a misleading "Unable to find adapter" message. Restricting the check to the first line of the error message fixes the false positive.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node's
MODULE_NOT_FOUNDerrors include a "Require stack" that liststhe calling file's path. The existing heuristic checked whether the
adapter path appeared anywhere in
err.messageto distinguish"adapter not found" from "adapter found but has a missing dependency."
Because the adapter's own path always appears in the require stack, the
check always matched, causing missing-dep errors to be silently
swallowed and replaced with a misleading "Unable to find adapter"
message.
Restricting the check to the first line of the error message fixes the
false positive.