Restored superagent and superagent-throttle dependencies#27766
Conversation
no-issue These were removed in 8f2ec8d as knip flagged them unused, but SchedulingPro (the Ghost(Pro) scheduling adapter, copied in at release time) depends on both packages. Without them, Ghost(Pro) crashes at boot with "Unable to find scheduling adapter SchedulingPro."
WalkthroughThis pull request adds two new npm packages to the project dependencies. The 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ghost/core/package.json (1)
234-235: ⚡ Quick winAdd
superagentandsuperagent-throttleto knip'signoreDependenciesallowlist.These dependencies are used by an external SchedulingPro adapter but knip's unused-dependency detection cannot see external usage. Add entries to the
ignoreDependenciesarray inknip.jsonto prevent automated cleanup from removing them in the future.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ghost/core/package.json` around lines 234 - 235, knip is flagging "superagent" and "superagent-throttle" as unused even though they're required by an external SchedulingPro adapter; update knip.json by adding "superagent" and "superagent-throttle" to the ignoreDependencies array so knip will skip them during unused-dependency checks, ensuring the entries match the package names exactly and are added alongside other ignored packages in the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@ghost/core/package.json`:
- Around line 234-235: knip is flagging "superagent" and "superagent-throttle"
as unused even though they're required by an external SchedulingPro adapter;
update knip.json by adding "superagent" and "superagent-throttle" to the
ignoreDependencies array so knip will skip them during unused-dependency checks,
ensuring the entries match the package names exactly and are added alongside
other ignored packages in the file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 874302da-a974-4367-85e3-550aa22e4ae7
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
ghost/core/package.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27766 +/- ##
=======================================
Coverage 73.17% 73.17%
=======================================
Files 1561 1561
Lines 127212 127212
Branches 15390 15388 -2
=======================================
+ Hits 93084 93087 +3
- Misses 33148 33166 +18
+ Partials 980 959 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
These were removed in 8f2ec8d as knip flagged them unused, but
SchedulingPro (the Ghost(Pro) scheduling adapter, copied in at release
time) depends on both packages. Without them, Ghost(Pro) crashes at
boot with "Unable to find scheduling adapter SchedulingPro."
knip can't see SchedulingPro because it lives outside the repo and is
injected during the release build.