Skip to content

Restored superagent and superagent-throttle dependencies#27766

Merged
allouis merged 1 commit into
mainfrom
restore-superagent-deps
May 7, 2026
Merged

Restored superagent and superagent-throttle dependencies#27766
allouis merged 1 commit into
mainfrom
restore-superagent-deps

Conversation

@allouis
Copy link
Copy Markdown
Collaborator

@allouis allouis commented May 7, 2026

These were removed in 8f2ec8d as knip flagged them unused, but
SchedulingPro (the Ghost(Pro) scheduling adapter, copied in at release
time) depends on both packages. Without them, Ghost(Pro) crashes at
boot with "Unable to find scheduling adapter SchedulingPro."

knip can't see SchedulingPro because it lives outside the repo and is
injected during the release build.

no-issue

These were removed in 8f2ec8d as knip flagged them unused, but
SchedulingPro (the Ghost(Pro) scheduling adapter, copied in at release
time) depends on both packages. Without them, Ghost(Pro) crashes at
boot with "Unable to find scheduling adapter SchedulingPro."
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Review Change Stack

Walkthrough

This pull request adds two new npm packages to the project dependencies. The superagent package (version 5.3.1) provides HTTP request functionality, and superagent-throttle (version 1.0.1) provides rate limiting capabilities. Both dependencies are added to the dependencies object in ghost/core/package.json with pinned versions. No other manifest fields or configuration are altered.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: restoring two previously removed dependencies (superagent and superagent-throttle).
Description check ✅ Passed The description provides relevant context explaining why the dependencies were removed, why they need to be restored, and clarifies the SchedulingPro dependency issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch restore-superagent-deps

Comment @coderabbitai help to get the list of available commands and usage tips.

@allouis allouis enabled auto-merge (rebase) May 7, 2026 11:22
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
ghost/core/package.json (1)

234-235: ⚡ Quick win

Add superagent and superagent-throttle to knip's ignoreDependencies allowlist.

These dependencies are used by an external SchedulingPro adapter but knip's unused-dependency detection cannot see external usage. Add entries to the ignoreDependencies array in knip.json to prevent automated cleanup from removing them in the future.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ghost/core/package.json` around lines 234 - 235, knip is flagging
"superagent" and "superagent-throttle" as unused even though they're required by
an external SchedulingPro adapter; update knip.json by adding "superagent" and
"superagent-throttle" to the ignoreDependencies array so knip will skip them
during unused-dependency checks, ensuring the entries match the package names
exactly and are added alongside other ignored packages in the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@ghost/core/package.json`:
- Around line 234-235: knip is flagging "superagent" and "superagent-throttle"
as unused even though they're required by an external SchedulingPro adapter;
update knip.json by adding "superagent" and "superagent-throttle" to the
ignoreDependencies array so knip will skip them during unused-dependency checks,
ensuring the entries match the package names exactly and are added alongside
other ignored packages in the file.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 874302da-a974-4367-85e3-550aa22e4ae7

📥 Commits

Reviewing files that changed from the base of the PR and between 0332bfa and 3fe401d.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • ghost/core/package.json

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.17%. Comparing base (0009ffb) to head (3fe401d).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #27766   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files        1561     1561           
  Lines      127212   127212           
  Branches    15390    15388    -2     
=======================================
+ Hits        93084    93087    +3     
- Misses      33148    33166   +18     
+ Partials      980      959   -21     
Flag Coverage Δ
admin-tests 49.88% <ø> (ø)
e2e-tests 73.17% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allouis allouis merged commit bbc3981 into main May 7, 2026
46 checks passed
@allouis allouis deleted the restore-superagent-deps branch May 7, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant