Fixed HTML entities appearing in Portal toast and heading text#27781
Conversation
Closes https://linear.app/ghost/issue/DES-1368/handle-apostrophes-in-names-in-portal, https://linear.app/ghost/issue/DES-1359/newsletter-names-with-and-display-incorrectly-in-popups i18next was escaping apostrophes and ampersands in interpolated values, mangling things like the subscribe toast. Disabled escaping for the portal namespace and removed three older per-call workarounds.
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughThis PR consolidates i18n interpolation handling for the portal package. The i18n factory in 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes https://linear.app/ghost/issue/DES-1368/handle-apostrophes-in-names-in-portal, https://linear.app/ghost/issue/DES-1359/newsletter-names-with-and-display-incorrectly-in-popups
i18next was escaping apostrophes and ampersands in interpolated values, mangling things like the subscribe toast. Disabled escaping for the portal namespace and removed three older per-call workarounds.