Skip to content

Small design tweaks for gift subscriptions#27805

Merged
minimaluminium merged 4 commits into
mainfrom
gift-subs-design-iterations-7
May 11, 2026
Merged

Small design tweaks for gift subscriptions#27805
minimaluminium merged 4 commits into
mainfrom
gift-subs-design-iterations-7

Conversation

@minimaluminium
Copy link
Copy Markdown
Member

ref https://linear.app/ghost/issue/BER-3600/design-iteration

  • Member activity uses one plain gift box icon for both started and expired events (was a slashed icon for expired)
  • Gift checkout subtitle wraps cleanly with text-wrap: pretty
  • Removed redundant "Shareable link" label on the gift success page

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 15cabf9d-e201-487f-8bd1-add65af3dbe3

📥 Commits

Reviewing files that changed from the base of the PR and between 39614f9 and 2a90b6f.

⛔ Files ignored due to path filters (1)
  • ghost/admin/public/assets/icons/event-expired-gift.svg is excluded by !**/*.svg
📒 Files selected for processing (5)
  • apps/portal/package.json
  • apps/portal/src/components/pages/gift-page.js
  • apps/portal/src/components/pages/gift-success-page.js
  • ghost/admin/app/helpers/parse-member-event.js
  • ghost/admin/tests/unit/helpers/parse-member-event-test.js
💤 Files with no reviewable changes (1)
  • apps/portal/src/components/pages/gift-success-page.js

Walkthrough

This PR updates gift-related features across the Ghost portal and admin applications. The member event helper icon mapping for gift_ended_event changes from expired-gift to gift, with a corresponding test update. The gift success page removes a "Shareable link" label element. The gift checkout page adds text-wrap styling to improve subtitle rendering. The portal package version is bumped to 2.68.36.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main purpose of the PR: small design improvements for gift subscription features.
Description check ✅ Passed The description is directly related to the changeset, clearly listing the three design tweaks made to gift subscription features.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gift-subs-design-iterations-7

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

gift_ended_event now reuses the same gift box icon as
gift_redemption_event instead of the slashed expired-gift variant, so
both started and expired entries in the member activity feed read as a
matched pair. Removed the now-unused event-expired-gift.svg.
Added text-wrap: pretty to the gift checkout subtitle so the multi-line
copy breaks cleanly instead of leaving a short orphan word on the last
line.
The label was redundant — the link itself with the copy button reads
clearly as a shareable URL on its own.
@minimaluminium minimaluminium force-pushed the gift-subs-design-iterations-7 branch from 709c897 to 7d08a55 Compare May 11, 2026 12:16
Changelog for v2.68.35 -> 2.68.36:
@minimaluminium minimaluminium merged commit ce05bda into main May 11, 2026
41 checks passed
@minimaluminium minimaluminium deleted the gift-subs-design-iterations-7 branch May 11, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant