Skip to content

Renamed notifyGiftReceived to notifyGiftPurchased#27807

Merged
sagzy merged 1 commit into
mainfrom
wonderful-hugle-67a8e1
May 11, 2026
Merged

Renamed notifyGiftReceived to notifyGiftPurchased#27807
sagzy merged 1 commit into
mainfrom
wonderful-hugle-67a8e1

Conversation

@sagzy
Copy link
Copy Markdown
Contributor

@sagzy sagzy commented May 11, 2026

ref https://linear.app/ghost/issue/BER-3554

  • Renamed notifyGiftReceived to notifyGiftPurchased across the gift service, staff service emails, and their unit tests - as this staff notification is sent when a gift is purchased
  • This change should have no user impact

- the email is sent to staff when a gift is purchased, not received
- renamed for clarity to better reflect when this notification fires
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Review Change Stack

Walkthrough

The PR renames the gift purchase staff notification method from notifyGiftReceived to notifyGiftPurchased. The StaffServiceEmails interface in GiftService and its implementation in staff-service-emails.js are updated with the new method name, while the method parameters and internal email formatting logic remain unchanged. GiftService's recordPurchase() method is updated to call the renamed notification method. All test files for both GiftService and StaffServiceEmails are updated to verify the renamed method instead of the previous one.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely summarizes the main change: renaming notifyGiftReceived to notifyGiftPurchased across multiple files and tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description accurately describes the changeset: renaming notifyGiftReceived to notifyGiftPurchased across gift service, staff service emails, and unit tests, with reference to the linear issue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch wonderful-hugle-67a8e1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sagzy sagzy merged commit 14a3433 into main May 11, 2026
44 checks passed
@sagzy sagzy deleted the wonderful-hugle-67a8e1 branch May 11, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant