Skip to content

Used proper capitalization in automation status badge#27855

Merged
troyciesco merged 2 commits into
mainfrom
proper-capitalization-for-automation-status-badge
May 19, 2026
Merged

Used proper capitalization in automation status badge#27855
troyciesco merged 2 commits into
mainfrom
proper-capitalization-for-automation-status-badge

Conversation

@EvanHahn
Copy link
Copy Markdown
Contributor

@EvanHahn EvanHahn commented May 12, 2026

ref #27854

Before (pseudocode):

<span>LIVE</span>

After (pseudocode):

<span class="uppercase">Live</span>

This has a few advantages:

  • More accessible. Screen readers will be able to read this more easily. This is the big reason.
  • "Live" will be copy-pasted, not "LIVE", which is probably (slightly) more desirable.
  • If we want it to look lowercase in the future, it's easier to change.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 26a45ce2-10ca-41c7-94e1-879c40b3d914

📥 Commits

Reviewing files that changed from the base of the PR and between 4a3802c and 7b0e697.

📒 Files selected for processing (2)
  • apps/posts/src/views/Automations/components/automation-status-badge.tsx
  • apps/posts/test/unit/views/automations/automations-list.test.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/posts/src/views/Automations/components/automation-status-badge.tsx

Walkthrough

This PR refactors the AutomationStatusBadge component to change the rendered status labels from all-caps LIVE and OFF to title-case Live and Off. The visual all-caps presentation is preserved by adding the uppercase CSS utility class to both badge variants. The corresponding unit test assertions are updated to expect the new label text values.

Possibly related PRs

  • TryGhost/Ghost#27851: Adjusts automation status label expectations from LIVE/OFF to Live/Off in related test assertions.
  • TryGhost/Ghost#27854: Updates the same AutomationStatusBadge component and associated tests with matching label text changes.

Suggested labels

ok to merge for me

Suggested reviewers

  • troyciesco
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: switching automation status badge labels to proper capitalization (Live/Off instead of LIVE/OFF) while using CSS for uppercase styling.
Description check ✅ Passed The description is directly related to the changeset, providing clear before/after pseudocode examples and explaining the accessibility and usability benefits of the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch proper-capitalization-for-automation-status-badge

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EvanHahn EvanHahn force-pushed the proper-capitalization-for-automation-status-badge branch from 7122401 to fbd355d Compare May 12, 2026 21:09
@EvanHahn EvanHahn force-pushed the off-and-live-in-automations-header branch from 3cfca9d to 45c5aa3 Compare May 12, 2026 22:07
Base automatically changed from off-and-live-in-automations-header to main May 13, 2026 13:15
@EvanHahn EvanHahn force-pushed the proper-capitalization-for-automation-status-badge branch from fbd355d to 4a3802c Compare May 13, 2026 14:13
ref #27854

Before (pseudocode):

```html
<span>LIVE</span>
```

After (pseudocode):

```html
<span class="uppercase">Live</span>
```

This has a few advantages:

- More accessible. Screen readers will be able to read this more easily.
  This is the big reason.
- "Live" will be copy-pasted, not "LIVE", which is probably (slightly)
  more desirable.
- If we want it to look lowercase in the future, it's easier to change.
@EvanHahn EvanHahn force-pushed the proper-capitalization-for-automation-status-badge branch from 4a3802c to 7b0e697 Compare May 13, 2026 14:27
@EvanHahn EvanHahn added the ok to merge for me You can merge this on my behalf if you want. label May 13, 2026
@EvanHahn EvanHahn requested a review from troyciesco May 19, 2026 19:22
@troyciesco troyciesco merged commit b14ffa9 into main May 19, 2026
41 checks passed
@troyciesco troyciesco deleted the proper-capitalization-for-automation-status-badge branch May 19, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok to merge for me You can merge this on my behalf if you want.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants