Hid welcome emails if automation labs flag is on

[EvanHahn]

closes https://linear.app/ghost/issue/NY-1251

Screencast.mp4

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: db792c44-920b-4eb8-b9f7-8eb0742d3912

📥 Commits

Reviewing files that changed from the base of the PR and between c5347f6 and ab7a64b.

📒 Files selected for processing (3)

• apps/admin-x-settings/src/components/settings/membership/membership-settings.tsx
• apps/admin-x-settings/src/components/sidebar.tsx
• apps/admin-x-settings/test/acceptance/membership/membership-settings.test.ts

🚧 Files skipped from review as they are similar to previous changes (3)

• apps/admin-x-settings/test/acceptance/membership/membership-settings.test.ts
• apps/admin-x-settings/src/components/settings/membership/membership-settings.tsx
• apps/admin-x-settings/src/components/sidebar.tsx

---

Walkthrough

This PR implements conditional visibility for the "Welcome emails" section in membership settings based on the automations feature flag. membership-settings imports the feature flag hook and filters SearchableSection keywords to exclude memberEmails when automations is enabled, rendering MemberEmails only when disabled. The sidebar mirrors this by computing visibleMembershipSearchKeywords and hiding the Welcome emails nav item when automations is enabled. Playwright acceptance tests assert both visible and hidden states via mocked browseConfig responses.

Suggested labels

ok to merge for me

Suggested reviewers

• troyciesco

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: hiding welcome emails when the automation labs flag is enabled, which aligns with the core changeset modifications.
Description check	✅ Passed	The description references a closed issue (NY-1251) and includes a visual asset link, which provides context for the changes made to conditionally hide welcome emails based on the automations feature flag.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch hide-welcome-emails-automation-lab

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[EvanHahn]

These were moved up, but were otherwise unchanged.